Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop in ShaderProgramPool._recursiveDestroy #1968

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

Sway007
Copy link
Member

@Sway007 Sway007 commented Jan 12, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@Sway007 Sway007 added bug Something isn't working shader Shader related functions high priority High priority issue labels Jan 12, 2024
@Sway007 Sway007 self-assigned this Jan 12, 2024
@GuoLei1990 GuoLei1990 merged commit b78e56d into galacean:dev/1.2 Jan 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority High priority issue shader Shader related functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants