New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: particle emission baseShape enabled #1983

Merged

GuoLei1990 merged 1 commit into galacean:dev/1.2 from JujieX:fix/particleShapeEnabled

Jan 23, 2024

Contributor

JujieX commented Jan 23, 2024 •

edited

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

old particle emission module baseshape enable won't work
change api name to enabled to align with engine api style


          fix: particle emission shape enabled

7cc0c20

JujieX added the bug label

JujieX requested a review from GuoLei1990

January 23, 2024 08:16

JujieX self-assigned this

GuoLei1990 approved these changes

View reviewed changes

GuoLei1990 merged commit d16001c into galacean:dev/1.2

5 of 6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment