Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug of global variable dosn't work in multi-pass ShaderLab #2018

Merged
merged 11 commits into from
Mar 11, 2024

Conversation

Sway007
Copy link
Member

@Sway007 Sway007 commented Mar 5, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fixed the problem of global variable serialization loss in multi-pass shader

@Sway007 Sway007 added bug Something isn't working shader Shader related functions high priority High priority issue labels Mar 5, 2024
@Sway007 Sway007 added this to the 1.2 milestone Mar 5, 2024
@Sway007 Sway007 self-assigned this Mar 5, 2024
@Sway007 Sway007 mentioned this pull request Mar 5, 2024
3 tasks
@Sway007 Sway007 changed the title Fix global variable serialization in multi-pass ShaderLab Fix the bug of global variable dosn't work in multi-pass ShaderLab Mar 11, 2024
@Sway007 Sway007 requested a review from GuoLei1990 March 11, 2024 07:40
@GuoLei1990 GuoLei1990 merged commit 74cb109 into galacean:dev/1.2 Mar 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority High priority issue shader Shader related functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants