Replace throw with console.error to prevent blocking the main thread
#2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuoLei1990
approved these changes
May 9, 2024
Sway007
approved these changes
May 9, 2024
GuoLei1990
approved these changes
May 9, 2024
GuoLei1990
changed the title
throw with console.error to prevent blocking the main threadthrow with console.error to prevent blocking the main thread
GuoLei1990
added a commit
to GuoLei1990/galacean-engine
that referenced
this pull request
Jun 3, 2024
* dev/1.3: fix: use default material to prevent material[] (galacean#2104) Add `Script` in `onStart` may cause some functions to not be executed correctly. (galacean#2102) "v1.2.0-beta.5" Redesign `Skin` of `SkinnedMeshRenderer` (galacean#2100) Fix glTF renderer component's order is random now (galacean#2097) "v1.2.0-beta.4" "v1.2.0-beta.3" Fix the bug of animation playback for multiple same type components under an Entity (galacean#2095) Support get any subAsset from GLTFParser (galacean#2093) Replace `throw` with `console.error` to prevent blocking the main thread (galacean#2077) Fixed the problem that function macro declaration is lost after compilation (galacean#2087)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This prevent tweaks the shader registration process to provide a better DX for developer.
What is the current behavior? (You can also link to an open issue here)
Currently, if Galacean detects a shader registered with the same name, it will throw an uncaught error, which will block the main thread.
What is the new behavior (if this is a feature change)?
We just console an error inside of throwing it to prevent blocking the user's main thread.