Add transition conditions #2096
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuoLei1990
requested changes
Jun 19, 2024
GuoLei1990
reviewed
Jun 19, 2024
| @@ -0,0 +1,11 @@ | |||
| export type AnimatorControllerParameterValue = number | string | boolean; | |||
There was a problem hiding this comment.
I think the types of values need to be limited
GuoLei1990
reviewed
Jun 19, 2024
GuoLei1990
reviewed
Jun 19, 2024
| addCondition( | ||
| mode: AnimatorConditionMode, | ||
| parameter: string, | ||
| threshold?: AnimatorControllerParameterValue |
There was a problem hiding this comment.
- Why threshold can be undefined
- The order should same with
AnimatorConditionconstructor
There was a problem hiding this comment.
Because AnimatorConditionMode may be IF means the parameter is true, AnimatorCondition will add '?'
GuoLei1990
reviewed
Jun 19, 2024
GuoLei1990
reviewed
Jun 19, 2024
GuoLei1990
reviewed
Jun 19, 2024
GuoLei1990
reviewed
Jun 19, 2024
| @@ -1,8 +1,17 @@ | |||
| /** | |||
| * The mode of the condition. | |||
There was a problem hiding this comment.
The mode of the animator condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: