ResourceManager support findResourcesByType
#1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuoLei1990
added
enhancement
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev/1.1 #1700 +/- ##
==========================================
Coverage ? 61.38%
==========================================
Files ? 410
Lines ? 21834
Branches ? 3140
==========================================
Hits ? 13403
Misses ? 7241
Partials ? 1190 ☔ View full report in Codecov by Sentry. |
gz65555
approved these changes
Aug 15, 2023
zhuxudong
added a commit
to zhuxudong/engine
that referenced
this pull request
Aug 17, 2023
* dev/1.1: (66 commits) build: fix pnpm lock file build: fix pnpm-lock file build: fix pnpm-lock file build: fix build error `ResourceManager` support `findResourcesByType` (galacean#1700) fix: memory leak of Transform (galacean#1701) fix: file name error "v1.1.0-alpha.1" test(RenderTarget): fix `getColorTexture` error Fix ktx2 loader can't throw error (galacean#1699) Enhance type for `LoadItem` & `Entity.getComponent` (galacean#1696) types: opt getComponent return type types: fix lint Fix ci test (galacean#1677) Shader Lab support `RenderState` (galacean#1664) feat: enhance type for `LoadItem` & `Entity.getComponent` fix: variable error (galacean#1693) `SkinnedMeshRenderer` support immediate initialization of `rootBone` and `bones` (galacean#1672) Support camera depth texture (galacean#1658) "v1.0.0-beta.18" ... # Conflicts: # packages/loader/src/gltf/parser/GLTFSceneParser.ts # packages/loader/src/gltf/parser/GLTFSkinParser.ts # tests/src/loader/GLTFLoader.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements