Support camera depth texture #1658

GuoLei1990 · 2023-07-22T12:42:43Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Feat:

Camera support depthTextureMode
Camera support pixelViewport

Playground:galacean/galacean.github.io#764

packages/core/src/Camera.ts

packages/core/src/RenderPipeline/DepthOnlyPass.ts

zhuxudong · 2023-08-01T09:43:47Z

packages/core/src/shader/ShaderPool.ts

      pipelineStage: PipelineStage.ShadowCaster
-    };
+    });
+    const basePasses = [depthOnlyPass, shadowCasterPass];


use [shadowCasterPass, depthOnlyPass] to be compatible with previous usage

zhuxudong · 2023-08-01T09:48:01Z

packages/core/src/shaderlib/extra/depthOnly.vs.glsl

+    #include <blendShape_vert>
+    #include <skinning_vert>
+
+    gl_Position = renderer_MVPMat * position;


why not use #include <position_vert>

zhuxudong · 2023-08-02T02:12:53Z

packages/core/src/shaderlib/extra/depthOnly.fs.glsl

@@ -0,0 +1,3 @@
+void main() {
+  gl_FragColor = vec4(0.0, 0.0, 0.0, 0.0);


delete this line is better

zhuxudong · 2023-08-02T02:15:26Z

packages/core/src/RenderPipeline/CullingResults.ts

+ * @internal
+ * Culling results.
+ */
+export class CullingResults {


why not called RendererQueueManager

The design is just save the cull info to save cull performance

zhuxudong · 2023-08-02T02:34:34Z

packages/core/src/RenderPipeline/PipelineUtils.ts

+   */
+  static recreateTextureIfNeeded(
+    engine: Engine,
+    currentTexture: Texture2D,


currentTexture: Texture2D | void

done with currentTexture: Texture2D | null

zhuxudong · 2023-08-02T02:35:57Z

packages/core/src/RenderPipeline/PipelineUtils.ts

+   */
+  static recreateRenderTargetIfNeeded(
+    engine: Engine,
+    currentRenderTarget: RenderTarget,


currentRenderTarget: RenderTarget | void

zhuxudong · 2023-08-02T02:37:27Z

packages/core/src/shadow/PipelinePass.ts

@@ -0,0 +1,21 @@
+import { Engine } from "../Engine";


this file should migrate to core/src/RenderPipeline

zhuxudong · 2023-08-02T02:46:00Z

packages/core/src/shadow/PipelinePass.ts

+export abstract class PipelinePass {
+  protected _engine: Engine;
+
+  constructor(engine: Engine) {


I think based on Camera is better, DepthOnlyPass and CascadedShadowCasterPass will be more suitable

Different camera use the same Pipeline pass instance, should not bind camera in constrouctor

zhuxudong · 2023-08-02T02:48:58Z

packages/core/src/shadow/PipelinePass.ts

+   * @param context - Rendering context
+   * @param cullingResults - Culling results
+   */
+  abstract onRender(context: RenderContext, cullingResults: CullingResults): void;


if based on camera, context and cullingResults can be ignored from camera.engine._renderContext and camera.renderPipeline._cullingResults

zhuxudong · 2023-08-02T02:55:05Z

packages/core/src/Camera.ts

@@ -32,9 +33,11 @@ class MathTemp {
 @dependentComponents(Transform, DependentMode.CheckOnly)
 export class Camera extends Component {
  /** @internal */
+  static _cameraTextureProperty = ShaderProperty.getByName("camera_DepthTexture");


_cameraDepthTextureProperty

zhuxudong · 2023-08-02T03:00:41Z

packages/core/src/RenderPipeline/BasicRenderPipeline.ts

@@ -179,7 +173,8 @@ export class BasicRenderPipeline {
    cubeFace?: TextureCubeFace,
    mipLevel?: number
  ) {
-    pass.preRender(camera, this._opaqueQueue, this._alphaTestQueue, this._transparentQueue);
+    const cullingResults = this._cullingResults;


const {opaqueQueue, alphaTestQueue, transparentQueue} = cullingResults;

* dev/1.1: (48 commits) fix: skin mesh error (galacean#1675) fix: test error (galacean#1674) test: fix github test (galacean#1669) test: fix ci not work (galacean#1670) glTF support basisu (galacean#1662) fix: `EventDispatcher` static pool bug fix: eventdispatcher bug (galacean#1671) fix: animation event bug (galacean#1666) Shader pass support blend (galacean#1668) Fix model mesh advanced data write bug (galacean#1663) Cherry pick glTF conflict (galacean#1660) Fix worker status set error and can't throw error bug (galacean#1652) Fix parse glTF texture wrap & filterMode bug (galacean#1659) Add shader lab package and support shader framework (galacean#1610) Fix text wrap bug (galacean#1644) chore: use strict error msg and type (galacean#1647) Fix text error for set text to "" and set enableWrapping to true (galacean#1634) "v1.0.0-beta.17" Process GLTFBufferParser and GLTFTextureParser pipelines in parallel (galacean#1638) Fix animation clip loader, clip change promise to assetPromise, controller json parse (galacean#1506) ...

cptbtptpbcptdtptp

+1

* dev/1.1: `SkinnedMeshRenderer` support immediate initialization of `rootBone` and `bones` (galacean#1672) Support camera depth texture (galacean#1658)

* dev/1.1: (66 commits) build: fix pnpm lock file build: fix pnpm-lock file build: fix pnpm-lock file build: fix build error `ResourceManager` support `findResourcesByType` (galacean#1700) fix: memory leak of Transform (galacean#1701) fix: file name error "v1.1.0-alpha.1" test(RenderTarget): fix `getColorTexture` error Fix ktx2 loader can't throw error (galacean#1699) Enhance type for `LoadItem` & `Entity.getComponent` (galacean#1696) types: opt getComponent return type types: fix lint Fix ci test (galacean#1677) Shader Lab support `RenderState` (galacean#1664) feat: enhance type for `LoadItem` & `Entity.getComponent` fix: variable error (galacean#1693) `SkinnedMeshRenderer` support immediate initialization of `rootBone` and `bones` (galacean#1672) Support camera depth texture (galacean#1658) "v1.0.0-beta.18" ... # Conflicts: # packages/loader/src/gltf/parser/GLTFSceneParser.ts # packages/loader/src/gltf/parser/GLTFSkinParser.ts # tests/src/loader/GLTFLoader.test.ts

GuoLei1990 added 2 commits July 20, 2023 00:41

refactor: opt code

54ee1b6

refactor: opt code

3d42897

GuoLei1990 marked this pull request as draft July 22, 2023 12:42

GuoLei1990 changed the base branch from main to dev/1.1 July 22, 2023 12:42

GuoLei1990 added 11 commits July 22, 2023 21:05

refactor: opt code

4155d39

refactor: opt code

27541b1

refactor: opt code

9ee4a1b

refactor: opt code

6a32546

refactor: opt code

e26a186

refactor: opt code

b449b1f

refactor: opt code

a9dfa3a

refactor: opt code

4de509e

refactor: opt code

38998a9

refactor: opt code

7eb52bb

refactor: opt code

fd8b46c

GuoLei1990 added the enhancement New feature or request label Jul 23, 2023

GuoLei1990 added this to the 1.1 milestone Jul 23, 2023

GuoLei1990 self-assigned this Jul 23, 2023

refactor: opt code

b040f80

GuoLei1990 requested review from zhuxudong and cptbtptpbcptdtptp July 23, 2023 08:37

GuoLei1990 added 8 commits July 25, 2023 11:35

refactor: opt code

9cd4361

refactor: opt code

1e141c6

refactor: opt code

e4b6e8f

refactor: opt code

9a48397

refactor: opt code

bb4edac

refactor: opt code

cefccd0

refactor: opt code

7b933a2

refactor: opt code

6cca96f

GuoLei1990 marked this pull request as ready for review July 26, 2023 11:06

GuoLei1990 linked an issue Jul 26, 2023 that may be closed by this pull request

Pipeline support Depth Texture #1550

Closed

GuoLei1990 added 2 commits July 26, 2023 19:37

refactor: opt code

4324007

refactor: opt code

e6c4fd7

cptbtptpbcptdtptp requested changes Jul 27, 2023

View reviewed changes

packages/core/src/Camera.ts Outdated Show resolved Hide resolved

packages/core/src/RenderPipeline/DepthOnlyPass.ts Show resolved Hide resolved

zhuxudong reviewed Aug 1, 2023

View reviewed changes

zhuxudong reviewed Aug 2, 2023

View reviewed changes

GuoLei1990 added 8 commits August 2, 2023 18:26

refactor: opt code

eebf1d1

refactor: opt code

bb77eb8

refactor: opt code

b6d7dc8

refactor: opt code

8827ff9

refactor: opt code

d9261cf

refactor: opt code

75edf40

refactor: opt code

f2e3697

cptbtptpbcptdtptp approved these changes Aug 4, 2023

View reviewed changes

zhuxudong approved these changes Aug 4, 2023

View reviewed changes

GuoLei1990 merged commit ce11f72 into galacean:dev/1.1 Aug 4, 2023
4 of 5 checks passed

GuoLei1990 deleted the PR/deth-texture branch September 18, 2023 14:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support camera depth texture #1658

Support camera depth texture #1658

GuoLei1990 commented Jul 22, 2023 •

edited

zhuxudong Aug 1, 2023

GuoLei1990 Aug 2, 2023

zhuxudong Aug 1, 2023

GuoLei1990 Aug 2, 2023

zhuxudong Aug 2, 2023

GuoLei1990 Aug 2, 2023

zhuxudong Aug 2, 2023

GuoLei1990 Aug 2, 2023

zhuxudong Aug 2, 2023

GuoLei1990 Aug 2, 2023

zhuxudong Aug 2, 2023

GuoLei1990 Aug 2, 2023

zhuxudong Aug 2, 2023

GuoLei1990 Aug 2, 2023

zhuxudong Aug 2, 2023

GuoLei1990 Aug 2, 2023

zhuxudong Aug 2, 2023

zhuxudong Aug 2, 2023

GuoLei1990 Aug 2, 2023

zhuxudong Aug 2, 2023

GuoLei1990 Aug 2, 2023

cptbtptpbcptdtptp left a comment

		@@ -0,0 +1,3 @@
		void main() {
		gl_FragColor = vec4(0.0, 0.0, 0.0, 0.0);

Support camera depth texture #1658

Support camera depth texture #1658

Conversation

GuoLei1990 commented Jul 22, 2023 • edited

Please check if the PR fulfills these requirements

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cptbtptpbcptdtptp left a comment

Choose a reason for hiding this comment

GuoLei1990 commented Jul 22, 2023 •

edited