Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OfferPlaced does not emit expire block #425

Closed
vikiival opened this issue Apr 11, 2022 · 1 comment
Closed

OfferPlaced does not emit expire block #425

vikiival opened this issue Apr 11, 2022 · 1 comment

Comments

@vikiival
Copy link

Description

Currently it's not possible for the indexers to obtain a blocknumber where the offer expires :)

Expected Behavior

Self::deposit_event(Event::OfferPlaced(sender, class_id, instance_id, amount, expires));

Actual Behavior

Self::deposit_event(Event::OfferPlaced(sender, class_id, instance_id, amount));

cc @green-jay (priority one pls)
@vikiival vikiival mentioned this issue Apr 11, 2022
Closed
@green-jay
Copy link
Contributor

green-jay commented Apr 18, 2022 •
edited

Fixed: 63720a3 and deployed to testnet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vikiival @green-jay