feat!: Integrate EMA Oracle (deprecated) #557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 43.89% // Head: 43.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #557 +/- ##
==========================================
- Coverage 43.89% 43.83% -0.06%
==========================================
Files 61 61
Lines 4406 4428 +22
==========================================
+ Hits 1934 1941 +7
- Misses 2472 2487 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…o apopiak/next-gen-oracle
…k-node into apopiak/next-gen-oracle
…o apopiak/next-gen-oracle
…o apopiak/next-gen-oracle
apopiak
commented
Jan 23, 2023
| @@ -0,0 +1,63 @@ | |||
| [package] | |||
| name = "pallet-exchange" | |||
There was a problem hiding this comment.
confused that this is showing up here 🤔
garbled merge (pull)?
There was a problem hiding this comment.
exchange have been deleted from pallets.
I noticed also some inconsistencies in math.
Perhaps, it would be worth considering to take the latest master, integrate just this and do the same in warehouse and math ?
There was a problem hiding this comment.
math and warehouse seem fine, no? would prefer not to lose the history there
I can do this here, yeah
apopiak
changed the title
The upgrade error doesn't seem related to this PR? |
…o apopiak/next-gen-oracle # Conflicts: # Cargo.lock # integration-tests/Cargo.toml # integration-tests/parachain-runtime-mock/Cargo.toml # pallets/duster/Cargo.toml # pallets/lbp/Cargo.toml # pallets/marketplace/Cargo.toml # pallets/xyk-liquidity-mining/Cargo.toml # pallets/xyk-liquidity-mining/benchmarking/Cargo.toml # pallets/xyk/Cargo.toml # primitives/Cargo.toml # runtime/basilisk/Cargo.toml # runtime/common/Cargo.toml # runtime/testing-basilisk/Cargo.toml
apopiak
commented
Jan 30, 2023
|
|
||
| parameter_types! { | ||
| pub SupportedPeriods: BoundedVec<OraclePeriod, ConstU32<MAX_PERIODS>> = BoundedVec::truncate_from( | ||
| vec![OraclePeriod::LastBlock, OraclePeriod::TenMinutes, OraclePeriod::Day, OraclePeriod::Week] |
|
no idea why code coverage is failing here, any ideas? |
|
superseded by #599 |
apopiak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate the EMA oracle from galacticcouncil/warehouse#76 into the Basilisk runtime.
Description
This PR adds the EMA oracle pallet and configures the runtime to ingest xyk trades and liquidity changes into it.
Supported periods are configured to
LastBlock,TenMinutes,DayandWeek.The oracle values are not used, yet, to allow for observation.
Related Issue
https://app.clickup.com/t/2v0w820
How Has This Been Tested?
Checklist: