feat: integrate EMA Oracle #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ add integration test + adjust xyk pallet to call pass data to the pallet
3 tasks
apopiak
commented
Feb 7, 2023
|
Crate versions that have been updated:
Runtime version has been increased. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #599 +/- ##
==========================================
- Coverage 43.73% 43.68% -0.05%
==========================================
Files 61 61
Lines 4466 4475 +9
==========================================
+ Hits 1953 1955 +2
- Misses 2513 2520 +7
☔ View full report in Codecov by Sentry. |
|
This should only need a rebenchmark based on the new max unique entries (now 30). |
apopiak
force-pushed
the
apopiak/oracle-integration
branch
from
5231292
to
9dac5e4
Compare
…o apopiak/oracle-integration
|
✅ Note: needs update to galacticcouncil/warehouse#188 |
|
warehouse PRs included:
|
…o apopiak/oracle-integration
…o apopiak/oracle-integration
mrq1911
reviewed
May 31, 2023
| @@ -494,7 +495,7 @@ impl pallet_xyk::Config for Runtime { | |||
| type MaxInRatio = MaxInRatio; | |||
| type MaxOutRatio = MaxOutRatio; | |||
| type CanCreatePool = pallet_lbp::DisallowWhenLBPPoolRunning<Runtime>; | |||
| type AMMHandler = (); | |||
| type AMMHandler = pallet_ema_oracle::OnActivityHandler<Runtime>; | |||
There was a problem hiding this comment.
shouldn't be xyk reweighted now with oracle?
# Conflicts: # runtime/basilisk/src/lib.rs # runtime/testing-basilisk/src/lib.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate the EMA oracle from galacticcouncil/warehouse#76 into the Basilisk runtime.
Description
This PR adds the EMA oracle pallet and configures the runtime to ingest xyk trades and liquidity changes into it.
Supported periods are configured to
LastBlock,Hour,DayandWeek.The oracle values are not used, yet, to allow for observation.
supersedes #557
Related Issue
https://app.clickup.com/t/2v0w820
How Has This Been Tested?
Includes an integration tests, most of the tests are in the pallet and its corresponding math package.
Checklist: