feat: NFT Auctions #168
Closed
feat: NFT Auctions #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrq1911
reviewed
Sep 21, 2022
green-jay
commented
Oct 31, 2022
| CannotChangeForbiddenAttribute, | ||
| } | ||
|
|
||
| #[pallet::call] |
There was a problem hiding this comment.
extrinsic header comments are missing all parameters descriptions, which are very important for code readability and anyone implementing FE
kuchta
reviewed
Nov 3, 2022
|
Closing this PR in favor of #592 The new PR has isolated English auction and resolved all applicable comments in this PR. TopUp and Candle auctions are left for a future implementation. Here is a summary of the most important TODOs for the future from this PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds NFT auctions with 3 auction types: English, TopUp and Candle
Early tech specification: https://www.notion.so/Auctions-6227f3d237e44baf8980e83eae74dbb7
https://github.com/w3f/Grants-Program/blob/master/applications/subauction.md
This should be merged to master with a call filter.
Weights and benchmarks to be updated at a later point.