Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve multi payment (builder review) #170

Merged
merged 5 commits into from
Sep 27, 2021

Conversation

enthusiastmartin
Copy link
Contributor

Builder review suggestions to use origin check rather than having a list of authorities which can add or remove accepted currency.

Also consolidated multi-payment config.

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #170 (36daed1) into master (6725da2) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage   86.11%   85.99%   -0.13%     
==========================================
  Files          21       21              
  Lines        2125     2092      -33     
==========================================
- Hits         1830     1799      -31     
+ Misses        295      293       -2     
Impacted Files Coverage Δ
.../transaction-multi-payment/benchmarking/src/lib.rs 100.00% <100.00%> (ø)
pallets/transaction-multi-payment/src/lib.rs 75.20% <100.00%> (-2.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6725da2...36daed1. Read the comment docs.

@enthusiastmartin enthusiastmartin linked an issue Sep 27, 2021 that may be closed by this pull request
Copy link
Member

@mrq1911 mrq1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: there is no migration that would kill whole authorities storage root, this shouldn't be a problem, because we have no authorities set yet anyway

@mrq1911 mrq1911 merged commit 92a0a3d into master Sep 27, 2021
@jak-pan jak-pan deleted the refactor/multi-payment-config branch February 22, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multi payment - replace member list with origin check
2 participants