test(exchange): resolve todos #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
=======================================
Coverage 83.55% 83.55%
=======================================
Files 21 21
Lines 2086 2086
=======================================
Hits 1743 1743
Misses 343 343 Continue to review full report at Codecov.
|
mrq1911
reviewed
Oct 25, 2021
| @@ -3367,7 +3381,7 @@ fn matching_limits_sell_buy_should_work() { | |||
| orml_tokens::Event::Reserved(asset_b, 2, 60000000000000).into(), | |||
| orml_tokens::Event::Reserved(asset_a, 3, 30000000000000).into(), | |||
| orml_tokens::Event::Reserved(asset_b, 2, 120000000000).into(), | |||
| orml_tokens::Event::Reserved(asset_b, 3, 60000000000).into(), //TODO: this is strange ?! should asset_a!! | |||
There was a problem hiding this comment.
@Roznovjak can you elaborate on how this was resolved?
There was a problem hiding this comment.
This is going to be resolved in separate PR as a fix. But right now the test follows the current implementation.
mrq1911
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.