chore: pin orml to specific revision #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martinfridrich why we just dont upgrade to 0.9.2? well have to upgrade to 0.9.3 anyway soon |
yes, sure. we can update. but as always,i'd expect some effort and this was jus to make sure that basilisk works ok even when it needs some updates. i would say that it would be probably good to have orml pinned some specific revision and update when necessary. |
mrq1911
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basilisk uses orml dependencies from master branch. Since there was a change to use more recent substrate version from different branch ( polkadot-v0.9.2) - doing any cargo update will result in having 2 different versions of substrate.
Basilisk is currently built with substrate from branch polkadot-v0.9.1
Therefore, this PR pins the orml to specific revision where the same version of substrate is used.