feat: add XYK liquidity mining pallet #527

dmoka · 2022-07-14T17:03:44Z

Description

Added implementation for XYK liquidity mining where we use the extracted liquidity mining pallet from warehouse repo.

TODO:

it is still not possible to create nft class for LM, so the migration/benchmark tests are not final
because of the same reason, the weights are not generated yet

Related Issue

Motivation and Context

How Has This Been Tested?

Checklist:

I have updated the documentation if necessary.
I have added tests to cover my changes, regression test if fixing an issue.
This is a breaking change.

…without balance

…alculation

Conflicts: Cargo.lock runtime/basilisk/Cargo.toml runtime/basilisk/src/lib.rs runtime/testing-basilisk/Cargo.toml runtime/testing-basilisk/src/lib.rs

github-actions · 2022-07-15T11:46:48Z

Crate versions that have not been updated:

pallet-xyk: v6.0.0

New crates:

pallet-xyk-liquidity-mining: v1.0.0
pallet-xyk-liquidity-mining-benchmarking: v1.0.0

Crate versions that have been updated:

basilisk: v7.0.0 -> v7.1.0
basilisk-runtime: v79.0.0 -> v80.0.0
common-runtime: v2.2.2 -> v2.2.3
testing-basilisk-runtime: v79.0.0 -> v80.0.0

Runtime version has been increased.

martinfridrich

I went only through pallets/liquidity-mining/src/lib.rs. This is not full review. More doc comments probably needs update and it require second look.

pallets/liquidity-mining/src/lib.rs

…to PR comments at #527

…time

enthusiastmartin

i havent looked at tests.

however, i have one additional concern and that's dusting of account where shares are transferred.

it should be excluded from dusting imo. eg. xyk pool accounts are excluded.

enthusiastmartin · 2022-10-19T07:58:08Z

pallets/xyk-liquidity-mining/Cargo.toml

@@ -0,0 +1,65 @@
+[package]
+name = "pallet-xyk-liquidity-mining"
+version = "1.3.0"


is this the first time the pallet is added ? why 1.3.0 then ?

previous version was in the runtime but it was never really used so maybe we can use 1.0.0

pallets/xyk-liquidity-mining/Cargo.toml

pallets/xyk-liquidity-mining/src/lib.rs

enthusiastmartin · 2022-10-19T08:54:32Z

pallets/xyk-liquidity-mining/src/lib.rs

+					who.clone(),
+					deposit_id,
+					yield_farm_id,
+					!fail_on_double_claim,


i dont quite get the double claim on/off.

accoprding to what i see - you can call claim_rewards and it fails on double claim.

however, instead of calling claim_rewards, you can call withdraw shares, and it calls claim_rewards which does not fail on double claim.

and this leads me to think to either "why it is needed at all" or "there can be a way to double claim potentially?!".

Users can claim rewards without withdrawing LP shares. This should fail if the user called claim 2nd times in the same period.
Withdrawing shares is claiming automatically and we don't want to penalise users by waiting for the next period to withdraw if the user has already claimed. So in this case 2nd claim should not fail.

enthusiastmartin · 2022-10-19T08:59:16Z

pallets/xyk-liquidity-mining/src/lib.rs

+
+			if is_destroyed {
+				Self::unlock_lp_tokens(asset_pair, who.clone(), withdrawn_amount)?;
+				T::NFTHandler::burn(&T::NftCollectionId::get(), &deposit_id, None)?;


have you considered using the maybe_check_owner ? just to make sure?

apopiak

First review (haven't looked at benchmarks and tests in-depth).
Sorry for the delay.

apopiak · 2022-10-20T09:53:19Z

pallets/xyk-liquidity-mining/Cargo.toml

+[dependencies]
+codec = { package = "parity-scale-codec", version = "3.1.5", features = ["derive", "max-encoded-len"], default-features = false }
+scale-info = { version = "2.1.2", default-features = false, features = ["derive"] }
+


Suggested change

apopiak · 2022-10-20T09:53:43Z

pallets/xyk-liquidity-mining/Cargo.toml

+scale-info = { version = "2.1.2", default-features = false, features = ["derive"] }
+
+
+sp-arithmetic = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.28", default-features = false }


should be part of the substrate deps below, no?

apopiak · 2022-10-20T09:54:44Z

pallets/xyk-liquidity-mining/Cargo.toml

+hydradx-traits-lm = { package="hydradx-traits", git = "https://github.com/galacticcouncil/warehouse", rev="89bde6d2b8bad2263c554eb3d83b76d877971136", default-features = false }
+
+pallet-nft = { git = "https://github.com/galacticcouncil/warehouse", branch="polkadot-v0.9.28", default-features = false }
+hydradx-traits = { git = "https://github.com/galacticcouncil/warehouse", branch="polkadot-v0.9.28", default-features = false }


you depend on 2 different versions of the traits crate, is this on purpose? Looks very odd and would warrant an explaining comment if it makes sense, no?

yes, it's intentional. Other pallets (xyk, nft) are using traits from master and LM is using trait from LM branch.
In my opinion warehouse LM should be merged first before we updates all the pallets to use the same trait. Otherwise we would have to do all the traits changes in the warehouse LM branch

apopiak · 2022-10-20T09:56:15Z

pallets/xyk-liquidity-mining/Cargo.toml

+orml-tokens = { git = "https://github.com/open-web3-stack/open-runtime-module-library", branch="polkadot-v0.9.28", default-features = false }
+pallet-balances = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.28", default-features = false }


you can remove the default-featues = false

apopiak · 2022-10-20T09:57:11Z

pallets/xyk-liquidity-mining/benchmarking/Cargo.toml

+frame-system-benchmarking = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.28", default-features = false }
+frame-benchmarking = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.28", default-features = false }
+
+orml-tokens = { git = "https://github.com/open-web3-stack/open-runtime-module-library", branch = "polkadot-v0.9.28", default-features = false }


should be with the other orml dep?

apopiak · 2022-10-20T11:08:33Z

runtime/testing-basilisk/src/lib.rs

@@ -919,6 +946,9 @@ construct_runtime!(
 		Marketplace: pallet_marketplace = 109,
 		TransactionPause: pallet_transaction_pause = 110,

+		LiquidityMining: pallet_xyk_liquidity_mining = 111,


nitpick: won't we have a stable swap liquidity mining? then this should be XYKLiqduityMining or similar

yes, I was thinking about renaming this but FE is already using it on testnet and my understanding was that we want to deploy it directly to rococo without testnet first.

apopiak · 2022-10-20T11:09:32Z

runtime/testing-basilisk/src/lib.rs

@@ -919,6 +946,9 @@ construct_runtime!(
 		Marketplace: pallet_marketplace = 109,
 		TransactionPause: pallet_transaction_pause = 110,

+		LiquidityMining: pallet_xyk_liquidity_mining = 111,
+		WarehouseLM: warehouse_liquidity_mining::<Instance1> = 112,


Suggested change

WarehouseLM: warehouse_liquidity_mining::<Instance1> = 112,

XYKWarehouseLM: warehouse_liquidity_mining::<XYKLiquidityMiningInstance> = 112,

would this be possible? (and would we want to specify the name of the instance on the left?)

This didn't work for me(use instance name instead of Instance1) but maybe I did something wrong I'll try it again

It's fine 🤷

apopiak · 2022-10-20T11:10:17Z

runtime/testing-basilisk/src/lib.rs

+	type BlockNumberProvider = cumulus_pallet_parachain_system::RelaychainBlockNumberProvider<Runtime>;
+	type NftCollectionId = LiquidityMiningNftCollectionId;
+	type AMM = XYK;
+	type WeightInfo = ();


ah, this is testing so not as important?

apopiak · 2022-10-20T11:12:05Z

runtime/common/src/lib.rs

+	pub const MinDeposit: Balance = 1;//TODO: tmp value
+	pub const MaxEntriesPerDeposit: u8 = 5; //NOTE: Rebenchmark when this change //TODO: tmp value
+	pub const MaxYieldFarmsPerGlobalFarm: u8 = 5; //TODO: tmp value
+	pub const MinPlannedYieldingPeriods: BlockNumber = 100;  //TODO: tmp value
+	pub const MinTotalFarmRewards: Balance = NATIVE_EXISTENTIAL_DEPOSIT * 1_000; //TODO: tmp value


This is for @jak-pan. I don't know what values we want

runtime/testing-basilisk/src/lib.rs

jak-pan · 2022-10-21T14:21:19Z

runtime/basilisk/src/lib.rs

@@ -858,7 +858,7 @@ impl pallet_relaychain_info::Config for Runtime {
 impl pallet_xyk_liquidity_mining::Config for Runtime {
 	type Event = Event;
 	type MultiCurrency = Currencies;
-	type CreateOrigin = EnsureRoot<AccountId>;
+	type CreateOrigin = SuperMajorityTechCommitteeOrRoot; //TODO: check this


I would do just root or full tech comm

enthusiastmartin

i havent checked closely tests nor benchmarks to see if they cover the worst case scenarios. If you have any doubts, we can dive in as this requires bit of effort to understand the LM itself.

enthusiastmartin · 2022-10-25T06:51:49Z

pallets/xyk-liquidity-mining/Cargo.toml

+hydradx-traits-lm = { package="hydradx-traits", git = "https://github.com/galacticcouncil/warehouse", rev="89bde6d2b8bad2263c554eb3d83b76d877971136", default-features = false }
+
+hydradx-traits = { git = "https://github.com/galacticcouncil/warehouse", branch="polkadot-v0.9.28", default-features = false }


i dont like this.

why it is not possible to have one ? probably needs to be merged to master ?

I don't lie it either :) but yes, warehosue LM pallets needs to be merged and other pallets(xyk, nft,...) needs to be updated to use the same trait version.

enthusiastmartin · 2022-10-25T06:52:18Z

pallets/xyk-liquidity-mining/benchmarking/Cargo.toml

@@ -0,0 +1,72 @@
+[package]
+name = "pallet-xyk-liquidity-mining-benchmarking"
+version = "1.1.0"


enthusiastmartin · 2022-10-25T06:53:16Z

pallets/xyk-liquidity-mining/Cargo.toml

+orml-traits = { git = "https://github.com/open-web3-stack/open-runtime-module-library", branch = "polkadot-v0.9.28", default-features = false }
+
+# HydraDX dependencies
+warehouse-liquidity-mining = { package="pallet-liquidity-mining", git = "https://github.com/galacticcouncil/warehouse", rev="89bde6d2b8bad2263c554eb3d83b76d877971136", default-features = false }


i guess it is possible now to use pallet-liquidity-mining as it has been renamed

enthusiastmartin · 2022-10-25T06:53:43Z

pallets/xyk-liquidity-mining/benchmarking/Cargo.toml

+# HydraDX dependencies
+pallet-nft = { git = "https://github.com/galacticcouncil/warehouse", branch = "polkadot-v0.9.28", default-features = false}
+pallet-asset-registry = { git = "https://github.com/galacticcouncil/warehouse", branch = "polkadot-v0.9.28", default-features = false }
+warehouse-liquidity-mining = { package="pallet-liquidity-mining", git = "https://github.com/galacticcouncil/warehouse", rev="89bde6d2b8bad2263c554eb3d83b76d877971136", default-features = false }


same here. no need of name change

enthusiastmartin · 2022-10-25T06:55:09Z

pallets/xyk-liquidity-mining/benchmarking/src/lib.rs

+	)?;
+
+	Ok(())


Suggested change

)?;

Ok(())

)

pallets/xyk-liquidity-mining/src/lib.rs

enthusiastmartin · 2022-10-25T07:14:55Z

pallets/xyk-liquidity-mining/src/lib.rs

+			Ok(())
+		}
+
+		/// Withdraw LP shares from liq. mining. with reward claiming if possible.


Suggested change

/// Withdraw LP shares from liq. mining. with reward claiming if possible.

/// Withdraw LP shares from liq. mining with reward claiming if possible.

enthusiastmartin · 2022-10-25T07:15:25Z

pallets/xyk-liquidity-mining/src/lib.rs

+
+		/// Withdraw LP shares from liq. mining. with reward claiming if possible.
+		///
+		/// Cases for transfer LP shares and claimed rewards:


this sentence doesn't make much sense to me.

List of possible cases of transfers of shares and rewards ?

pallets/xyk-liquidity-mining/src/lib.rs

apopiak

👍 for extensive test coverage

2 Points on the benchmarks:

I think it would be good to add verify clauses for the benchmarks.
I suspect the withdraw_shares benchmark is not measuring the worst case.

Seems fine to merge once withdraw_shares benchmark is checked and/or extended.

apopiak · 2022-10-25T10:22:45Z

pallets/xyk-liquidity-mining/benchmarking/src/lib.rs

+		lm_create_yield_farm::<T>(caller.clone(), GLOBAL_FARM_ID, ASSET_PAIR, FixedU128::one())?;
+
+		lm_deposit_shares::<T>(liq_provider, ASSET_PAIR, 10_000)?;
+		set_block_number::<T>(200_000);


I assume this is to make sure that the farm has entered the next period?

yes, this is to change the period and to make sure the farm's RPZ update happens

apopiak · 2022-10-25T10:27:50Z

pallets/xyk-liquidity-mining/benchmarking/src/lib.rs

+		set_block_number::<T>(200_000);
+	}: {
+		LiquidityMining::<T>::destroy_global_farm(RawOrigin::Signed(caller.clone()).into(), GLOBAL_FARM_ID)?
+	}


You'll want to verify that the farm was removed from storage, no?

apopiak · 2022-10-25T10:34:26Z

pallets/xyk-liquidity-mining/benchmarking/src/lib.rs

+		lm_create_yield_farm::<T>(caller.clone(), GLOBAL_FARM_ID, ASSET_PAIR, FixedU128::one())?;
+
+		lm_deposit_shares::<T>(liq_provider, ASSET_PAIR, 10_000)?;
+		set_block_number::<T>(100_000);


These are to ensure that the global farm needs updating I assume?

apopiak · 2022-10-25T10:40:02Z

pallets/xyk-liquidity-mining/benchmarking/src/lib.rs

+
+		LiquidityMining::<T>::deposit_shares(RawOrigin::Signed(liq_provider.clone()).into(), GLOBAL_FARM_ID, 3, bsx_dot, shares_amount)?;
+
+		set_block_number::<T>(400_000);


If this is about periods, how about expressing these as such?
E.g. set_block_number::<T>(period_to_blocks(4)) or similar

apopiak · 2022-10-25T10:46:22Z

pallets/xyk-liquidity-mining/src/lib.rs

+		///
+		/// Emits `SharesRedeposited` event when successful.
+		#[pallet::weight(<T as Config>::WeightInfo::redeposit_lp_shares())]
+		pub fn redeposit_lp_shares(


this naming is inconsistent with deposit_shares above

apopiak · 2022-10-25T10:51:42Z

pallets/xyk-liquidity-mining/benchmarking/src/lib.rs

+		LiquidityMining::<T>::deposit_shares(RawOrigin::Signed(liq_provider.clone()).into(), GLOBAL_FARM_ID, YIELD_FARM_ID, ASSET_PAIR, shares_amount)?;
+		LiquidityMining::<T>::redeposit_lp_shares(RawOrigin::Signed(liq_provider.clone()).into(), GLOBAL_FARM_ID_2, YIELD_FARM_ID_2, ASSET_PAIR, DEPOSIT_ID)?;
+		LiquidityMining::<T>::redeposit_lp_shares(RawOrigin::Signed(liq_provider.clone()).into(), 5, 6, ASSET_PAIR, DEPOSIT_ID)?;
+		LiquidityMining::<T>::redeposit_lp_shares(RawOrigin::Signed(liq_provider.clone()).into(), 7, 8, ASSET_PAIR, DEPOSIT_ID)?;


Surprised at all these (re)deposits. Want to add an explanatory comment (and why this setup is not necessary for the regular deposit benchmark)?

I'll double check but I think there was a difference when there was only 1 entry in the deposit. I'll add comment.
In the regular deposit it's not necessary because it creates new deposit

apopiak · 2022-10-25T11:00:04Z

pallets/xyk-liquidity-mining/benchmarking/src/lib.rs

+	}: {
+		LiquidityMining::<T>::withdraw_shares(RawOrigin::Signed(liq_provider.clone()).into(), DEPOSIT_ID, YIELD_FARM_ID, ASSET_PAIR)?
+	} verify {
+		assert!(MultiCurrencyOf::<T>::free_balance(BSX, &liq_provider).gt(&liq_provider_bsx_balance));
+	}


You probably want to trigger (and then check) the case where it is destroyed?

withdraw_shares is quite complex so I'm somewhat skeptical that you've covered the worst case with this short benchmark.

You might even want 2 or 3 for the different scenarios and then compare them in terms of their weight.

yes, I think I compared case when deposit is destroyed and this one was worse. I'll double check and add comment.

apopiak · 2022-10-25T11:08:20Z

pallets/xyk-liquidity-mining/src/tests/withdraw_shares.rs

+}
+
+#[test]
+fn deposit_shares_should_fail_when_origin_is_not_signed() {


Suggested change

fn deposit_shares_should_fail_when_origin_is_not_signed() {

fn withdraw_shares_should_fail_when_origin_is_not_signed() {

apopiak · 2022-10-25T11:11:30Z

pallets/xyk-liquidity-mining/src/lib.rs

+	pub enum Error<T> {
+		/// Nft pallet didn't return an owner.
+		CantFindDepositOwner,
+
+		/// Account balance of amm pool shares is not sufficient.
+		InsufficientAmmSharesBalance,
+
+		/// AMM pool does not exist
+		AmmPoolDoesNotExist,
+
+		/// Account is not deposit owner.
+		NotDepositOwner,
+
+		/// AMM did not return assets for given `amm_pool_id`
+		CantGetAmmAssets,
+
+		/// Yield farm can not be found
+		YieldFarmNotFound,
+
+		///Deposit data not found
+		DepositDataNotFound,
+
+		/// Calculated reward to claim is 0.
+		ZeroClaimedRewards,
+	}


Missing tests for CantFindDepositOwner, CantGetAmmAssets, YieldFarmNotFound

enthusiastmartin

resolve the TODO and lgtm

mrq1911

LGTM

mrq1911

LGTM

dmoka and others added 19 commits June 30, 2022 11:28

Add basilisk liquidity mining pallet

c718c7f

liquidity mining runtime cofiguration update

0f4f1dd

fix project build - implement warehouse lm config for Runtime

c233244

use the configured instance id for warehouse lm pallet

0c7ce6a

add benchmark for liquidty mining - WIP

219b414

benchmarks udpate

87f00a1

fix build - use the same and latest pallet-nft dependency everywhere

1bedf5a

update licenses

016d4ee

Adjust license

a759612

use stub for nft handler as the real dependency can't create classes …

361550e

…without balance

add verifications to benchmark tests

af5ad66

remove duplications in tests

ead2c0c

improve test to have the most computatinal heavy path for benchmark c…

c34106a

…alculation

Clean up in tests

d52063b

Fix and clean up todos

4e8bbe8

remove unused dependency

8ffaacd

add liquidity mining benchmark to testing basilisk runtime

2fa39cc

removed todo as it not needed anymore

f5804f6

add todo for regenerating weight

3d613fb

dmoka changed the title ~~Feat: add XYK liquidity mining pallet~~ feat: add XYK liquidity mining pallet Jul 14, 2022

fixed clippy warnings

705948a

dmoka marked this pull request as draft July 15, 2022 11:20

dmoka added 2 commits July 15, 2022 13:25

Merge master to feat/add-liquidity-mining-pallet

224df1b

Conflicts: Cargo.lock runtime/basilisk/Cargo.toml runtime/basilisk/src/lib.rs runtime/testing-basilisk/Cargo.toml runtime/testing-basilisk/src/lib.rs

bump runtime versions to the latest

b8ebd24

martinfridrich reviewed Jul 15, 2022

View reviewed changes

dmoka added 4 commits July 16, 2022 09:40

add doc about liq mining multiple incentives

5bc8b0d

remove unused clippy ignores

33862e5

use pool id and farm multiplier from warehouse lm dependency

10228eb

Additional renaming and cleanup in liq minding extrinsics, according …

2f9a0e1

…to PR comments at #527

martinfridrich added 2 commits October 13, 2022 16:52

make clippy happy

c5d6770

allowed LM for xyk in basilisk and renamed LM pallet in construct run…

fabf078

…time

martinfridrich changed the base branch from master to polkadot-v0.9.28 October 19, 2022 07:56

enthusiastmartin reviewed Oct 19, 2022

View reviewed changes

martinfridrich added 2 commits October 19, 2022 16:38

fix PR comments

0d410fc

bump versions

bf1d2f0

martinfridrich requested a review from enthusiastmartin October 20, 2022 09:15

apopiak reviewed Oct 20, 2022

View reviewed changes

martinfridrich added 3 commits October 20, 2022 16:52

add LM pallet account into non dustable

fef9bf4

fix pr comments

bf3532e

bump version, changed CreateOrigin for xyk LM pallet

2ebde0d

jak-pan reviewed Oct 21, 2022

View reviewed changes

martinfridrich added 2 commits October 21, 2022 16:38

Added comment about CreateOrigin

206d994

Changed xyk LM CreateOrigin to full tech committe or root

cf5582f

martinfridrich requested a review from apopiak October 21, 2022 15:14

enthusiastmartin reviewed Oct 25, 2022

View reviewed changes

apopiak approved these changes Oct 25, 2022

View reviewed changes

martinfridrich changed the base branch from polkadot-v0.9.28 to master October 25, 2022 15:52

martinfridrich added 2 commits October 26, 2022 14:19

PR fixes

c335edf

Merge branch 'master' into feat/add-liquidity-mining-pallet

2b826f6

enthusiastmartin approved these changes Oct 26, 2022

View reviewed changes

added integrity_test to check if CollectionId from reserved range

e065426

mrq1911 approved these changes Oct 28, 2022

View reviewed changes

martinfridrich added 4 commits October 31, 2022 08:30

Updated LM runtime configuration

8717f9e

Merge branch 'master' into feat/add-liquidity-mining-pallet

062b2b1

bump version

e169c40

updated Cargo.lock

5e3cc67

martinfridrich merged commit 377024d into master Oct 31, 2022

jak-pan deleted the feat/add-liquidity-mining-pallet branch February 22, 2024 10:59

		scale-info = { version = "2.1.2", default-features = false, features = ["derive"] }


		sp-arithmetic = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.28", default-features = false }

		orml-tokens = { git = "https://github.com/open-web3-stack/open-runtime-module-library", branch="polkadot-v0.9.28", default-features = false }
		pallet-balances = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.28", default-features = false }

	WarehouseLM: warehouse_liquidity_mining::<Instance1> = 112,
	XYKWarehouseLM: warehouse_liquidity_mining::<XYKLiquidityMiningInstance> = 112,

		hydradx-traits-lm = { package="hydradx-traits", git = "https://github.com/galacticcouncil/warehouse", rev="89bde6d2b8bad2263c554eb3d83b76d877971136", default-features = false }

		hydradx-traits = { git = "https://github.com/galacticcouncil/warehouse", branch="polkadot-v0.9.28", default-features = false }

-	)?;
-	Ok(())
+	)

	/// Withdraw LP shares from liq. mining. with reward claiming if possible.
	/// Withdraw LP shares from liq. mining with reward claiming if possible.


		LiquidityMining::<T>::deposit_shares(RawOrigin::Signed(liq_provider.clone()).into(), GLOBAL_FARM_ID, 3, bsx_dot, shares_amount)?;

		set_block_number::<T>(400_000);

	fn deposit_shares_should_fail_when_origin_is_not_signed() {
	fn withdraw_shares_should_fail_when_origin_is_not_signed() {

feat: add XYK liquidity mining pallet #527

feat: add XYK liquidity mining pallet #527

Conversation

dmoka commented Jul 14, 2022 • edited

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Checklist:

github-actions bot commented Jul 15, 2022 • edited

martinfridrich left a comment

Choose a reason for hiding this comment

enthusiastmartin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

apopiak left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

martinfridrich Oct 20, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

enthusiastmartin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

apopiak left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

enthusiastmartin left a comment

Choose a reason for hiding this comment

mrq1911 left a comment

Choose a reason for hiding this comment

mrq1911 left a comment

Choose a reason for hiding this comment

dmoka commented Jul 14, 2022 •

edited

github-actions bot commented Jul 15, 2022 •

edited

martinfridrich Oct 20, 2022 •

edited