chore: upgrade to polkadot v0.9.28 #564
Conversation
…/Basilisk-node into polkadot-v0.9.26
|
Where did you find this line? I can't find it. XcmConfig doesn't have this field. |
From your PR description up above :-D |
Yes, you are right. I will update the description. And yes, we don't have benchmarks for it. @enthusiastmartin what to do if we want to add benchmarks for a pallet that we haven't benchmarked before? Is it enough to just add new file with the default weights to the |
| let _ = <ExchangeAssetsIntentionCount<T>>::clear(u32::MAX, None); | ||
| let _ = <ExchangeAssetsIntentions<T>>::clear(u32::MAX, None); |
There was a problem hiding this comment.
How is ExchangeAssetsIntentions bounded?
Not the purpose of this PR, but we should know and it should be documented IMO
There was a problem hiding this comment.
Doesn't need to block merging this PR I guess as it's a different concern, but we should have a task tracking this IMO
| // The latest versions of the orml-currencies pallet don't emit events. | ||
| // The infrastructure relies on the events from this pallet, so we use the latest version of | ||
| // the pallet that contains and emit events and was updated to the polkadot version we use. | ||
| impl pallet_currencies::Config for Runtime { |
There was a problem hiding this comment.
I'm confused, I saw the events being removed from some tests, no?
| orml_currencies::Event::Transferred { | ||
| currency_id, | ||
| from: *ALICE, | ||
| to: *TREASURY, | ||
| amount: 500, | ||
| } | ||
| .into(), |
There was a problem hiding this comment.
There is a comment in the runtime that orml_currencies was forked to keep these events, but they seem to be removed here?
There was a problem hiding this comment.
I removed orml events that followed events from the balances or tokens pallets. So we test that transfers are executed.
There was a problem hiding this comment.
Ah, so pallet_currencies keeps some but not all events?
There was a problem hiding this comment.
It keeps all events, but I removed events from tests if there was an event from balances or tokens corresponding to the same transfer. A transfer emits two events, one from balances/tokens and one from currencies
They need to be added in the benchmark listing in the runtime lib.rs, no? |
Notable changes:
Rename:
Class->Collection,Instance->ItemUse our own copy of
orml_currenciespallet fromwarehouseNew benchmarking commands (
node/src/command.rs)No need for
#[transactional]macroImplemented migration for
pallet_nftin warehouseImplemented migration for
pallet_marketplaceAdded migration for
pallet_uniquesThe version of
fixedcrate fixed to1.17.0Use
polkadotwith patched XCM executorAdd
cumulus_pallet_xcmp_queueto benchmarkingNew or updated runtime configuration parameters:
orml_tokens::MaxReserves = 50orml_tokens::ReserveIdentifier = ()pallet_currencies::CheckAssociatedRelayNumber = RelayNumberStrictlyIncreasespallet_elections_phragmen::MaxCandidated = 1_000pallet_elections_phragmen::MaxVoters = 10_000pallet_uniques::CreateOrigin = NeverEnsureOriginpallet_uniques::Locker = ()cumulus_pallet_xcmp_queue::WeightInfo = ()orml_xtokens::MultiLocationsFilter = Everytingorml_xtokens::ReserveProvider = AbsoluteReserveProviderorml_xtokens::MinXcmFee = ParachainMinFee