Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xyk): test max in/out ratios #570

Merged
merged 4 commits into from
Oct 28, 2022
Merged

Conversation

Roznovjak
Copy link
Collaborator

Fixes: #566

@Roznovjak Roznovjak self-assigned this Oct 25, 2022
@github-actions
Copy link

github-actions bot commented Oct 25, 2022

Crate versions that have not been updated:

  • pallet-xyk: v6.0.0

Runtime version has not been increased.

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 78.75% // Head: 78.87% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (4bd9640) compared to base (95d54b1).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 4bd9640 differs from pull request most recent head b5808ce. Consider uploading reports for the commit b5808ce to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
+ Coverage   78.75%   78.87%   +0.12%     
==========================================
  Files          22       22              
  Lines        2104     2116      +12     
==========================================
+ Hits         1657     1669      +12     
  Misses        447      447              
Impacted Files Coverage Δ
pallets/xyk/src/lib.rs 85.37% <100.00%> (+0.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Roznovjak
Copy link
Collaborator Author

I had to change the value of MaxOutRatio in one test because I believe it's not possible to reach the limit and test it if the ratios are set to 1/3.

@Roznovjak Roznovjak changed the title feat(xyk): test MaxInRatio in buy feat(xyk): test max in/out ratios Oct 26, 2022
@mrq1911 mrq1911 merged commit f407ca7 into master Oct 28, 2022
@jak-pan jak-pan deleted the feat/check_max_out_and_in_ratios branch February 22, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change: xyk - check max out/in ratio in sell/buy
2 participants