fix: lm redeposit_lp_shares() #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crate versions that have been updated:
Runtime version has been increased. |
Roznovjak
reviewed
Jan 25, 2023
integration-tests/Cargo.toml
Outdated
| pallet-nft = { git = "https://github.com/galacticcouncil/warehouse", rev = "e85c3c68708c7d9789d18c0a230efd436fc5ea10", default-features = false } | ||
| pallet-currencies = { git = "https://github.com/galacticcouncil/warehouse", rev = "e85c3c68708c7d9789d18c0a230efd436fc5ea10", default-features = false } | ||
| pallet-route-executor = { git = "https://github.com/galacticcouncil/warehouse", rev = "e85c3c68708c7d9789d18c0a230efd436fc5ea10", default-features = false } | ||
| pallet-transaction-multi-payment = { git = "https://github.com/galacticcouncil/warehouse", rev = "a7e28a3a7fba655d9d27668097a1666f4250a495", default-features = false} |
There was a problem hiding this comment.
latest commit
Suggested change
| pallet-transaction-multi-payment = { git = "https://github.com/galacticcouncil/warehouse", rev = "a7e28a3a7fba655d9d27668097a1666f4250a495", default-features = false} | |
| pallet-transaction-multi-payment = { git = "https://github.com/galacticcouncil/warehouse", rev = "4223029df725ee9377d86fa5e02b220c59619cf6", default-features = false} |
There was a problem hiding this comment.
you can use this command to replace it everywhere sed -i '' 's/e85c3c68708c7d9789d18c0a230efd436fc5ea10/4223029df725ee9377d86fa5e02b220c59619cf6/g' ./**/*.toml
Codecov ReportBase: 84.07% // Head: 43.89% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #596 +/- ##
===========================================
- Coverage 84.07% 43.89% -40.18%
===========================================
Files 15 61 +46
Lines 1777 4406 +2629
===========================================
+ Hits 1494 1934 +440
- Misses 283 2472 +2189
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Roznovjak
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates repo to latest warehouse and fixes bug in liquidity-mining's
redeposit_lp_shares()function.Bug:
AssetPairprovided toredeposit_lp_shares()by users is not checked withDepositso users can provide differentAssetPairthan isDepositfor.This can result in wrong information in the event or/and bypassing xyk pool existence check.
Solution:
Check
amm_pool_idfrom the deposit withamm_pool_idgenerated fromAssetPair.