-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: xcm with computed origin config #633
Conversation
Crate versions that have been updated:
Runtime version has been increased. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #633 +/- ##
==========================================
- Coverage 49.67% 49.54% -0.13%
==========================================
Files 60 60
Lines 3867 3865 -2
==========================================
- Hits 1921 1915 -6
- Misses 1946 1950 +4
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine after addressing comments
Based on a discussion with @apopiak, where we reviewed the XCM changes proposed by the Substrate builders programme in this PR #591, we decided to make the following changes:
WithComputedOrigin
derivative barrier withAllowTopLevelPaidExecutionFrom
andAllowSubscriptionsFrom
barriers. This outer barrier computes the effective origin (checks for any origin altering operations) and passes this updated origin to inner barriers.XcmExecuteFilter
fromEverything
toNothing
. This change disallowspallet_xcm::execute
extrinsic which allows sending arbitrary XCM messages. We are not aware of any issues with this param set toEverything
, but better be sure. Moreover,pallet_xcm
is blocked by the runtime call filter.