feat: Add HashedDescription XCM converter and remove TinkernetMultisig configs #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arrudagates
changed the title
green-jay
approved these changes
Feb 22, 2024
|
Needs version bumps otherwise lgtm @jak-pan |
|
@green-jay Any other blockers on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the common XCM location converter HashedDescription, which is used across the ecosystem, to Basilisk.
Since the current Polkadot SDK version in use does not contain the
DescribeBodyTerminalconfig, it is also temporarily pulled locally intoxcm.rs, to be removed once the runtime is upgraded to polkadot-v1.2.0, which adds it to DescribeAllTerminal.For reference, chains using HashedDescription include the relay chain and system parachains like the Asset Hub.