New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(multipayment)!: use fallback in set_currency #93
Conversation
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 86.72% 87.39% +0.66%
==========================================
Files 17 17
Lines 1793 1793
==========================================
+ Hits 1555 1567 +12
+ Misses 238 226 -12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok. However there is a change in xyk pallet which has introduced trading limits. So the test would need some adjustments when merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok.
However the withdrawal is not yet enabled in the runtime. It needs to be set to Yes.
Description
Use fallback account and price in set_currency() if the corresponding pool does not exist.
Add missing tests found by code coverage tools.