Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multipayment)!: use fallback in set_currency #93

Merged
merged 7 commits into from Jul 7, 2021

Conversation

Roznovjak
Copy link
Collaborator

Description

Use fallback account and price in set_currency() if the corresponding pool does not exist.
Add missing tests found by code coverage tools.

@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #93 (f37a3de) into master (8e88a07) will increase coverage by 0.66%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   86.72%   87.39%   +0.66%     
==========================================
  Files          17       17              
  Lines        1793     1793              
==========================================
+ Hits         1555     1567      +12     
+ Misses        238      226      -12     
Impacted Files Coverage Δ
pallets/transaction-multi-payment/src/lib.rs 80.64% <100.00%> (+9.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e88a07...f37a3de. Read the comment docs.

Copy link
Contributor

@enthusiastmartin enthusiastmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok. However there is a change in xyk pallet which has introduced trading limits. So the test would need some adjustments when merged.

pallets/transaction-multi-payment/src/lib.rs Show resolved Hide resolved
Copy link
Contributor

@enthusiastmartin enthusiastmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

However the withdrawal is not yet enabled in the runtime. It needs to be set to Yes.

@Roznovjak Roznovjak merged commit 7df2c39 into master Jul 7, 2021
@Roznovjak Roznovjak deleted the test/multi_payment branch July 7, 2021 13:03
@jak-pan jak-pan changed the title feat(multipayment): use fallback in set_currency feat(multipayment)!: use fallback in set_currency Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants