Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use latest math package #99

Merged
merged 3 commits into from Jul 12, 2021
Merged

chore: use latest math package #99

merged 3 commits into from Jul 12, 2021

Conversation

enthusiastmartin
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 11, 2021

Codecov Report

Merging #99 (48b965a) into master (e826631) will decrease coverage by 0.04%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   87.40%   87.35%   -0.05%     
==========================================
  Files          17       17              
  Lines        1794     1795       +1     
==========================================
  Hits         1568     1568              
- Misses        226      227       +1     
Impacted Files Coverage Δ
pallets/xyk/src/lib.rs 83.71% <62.50%> (-0.28%) ⬇️
pallets/lbp/src/benchmarking.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e826631...48b965a. Read the comment docs.

Copy link
Collaborator

@Roznovjak Roznovjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the runtime version needs to be bumped.

@enthusiastmartin
Copy link
Contributor Author

I think that the runtime version needs to be bumped.

yes, that's the thing i have problem with. Previous merged PR bumped the runtime version but that was not released yet. So the same runtime version can be used with this change too.

@jak-pan am i right ?

I know that this is something we already talked about but i am still not happy bumping runtime version with every PR.

@jak-pan
Copy link
Contributor

jak-pan commented Jul 12, 2021

Always bump the runtime if needed, it's not because of release but because the developers that will be running this and our own infrastructure that will be testing compatiility between commits. If you don't bump it someone might run this successfully for a while and then it will crash for him because the runtime will be incompatible at given function call. We want to avoid these errors.

@jak-pan jak-pan merged commit 877a18e into master Jul 12, 2021
@mrq1911 mrq1911 deleted the chore/math-3.3.0 branch October 4, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants