Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: governance #183

Merged
merged 13 commits into from
Mar 31, 2021
Merged

feat!: governance #183

merged 13 commits into from
Mar 31, 2021

Conversation

green-jay
Copy link
Contributor

@green-jay green-jay commented Mar 25, 2021

Description

Add governance features for stakenet

Related Issue

Fixes: #166
Fixes: #174
Fixes: #181

@green-jay green-jay changed the title Feat!: governance feat!: governance Mar 25, 2021
pub const CENTS: Balance = DOLLARS / 100;
pub const MILLICENTS: Balance = CENTS / 1_000;

pub const FORTUNE: Balance = u128::MAX;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have this here? (Didn't find it used anywhere)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to be used for disabling certain features (e.g. set for minimum candidacy bond to council)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't that kick our councillor also? Or is it that once he's in he's there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I meant as an example, is a prevention for other accounts to submit their candidacy to council

/// Two thirds of the technical committee can have an ExternalMajority/ExternalDefault vote
/// be tabled immediately and with a shorter voting/enactment period.
type FastTrackOrigin = pallet_collective::EnsureMember<AccountId, CouncilCollective>;
type InstantOrigin = pallet_collective::EnsureMember<AccountId, CouncilCollective>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is adding sudo here possibly worth it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not worth discussing at this point (these fast tracks should be handled by techcomm i guess). Democracy might even be disabled for testnet, as we might want to avoid public proposals for systemic changes and leave it only for tech.comm proposals?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to dig deeper into it if that is even possible

@jak-pan
Copy link
Contributor

jak-pan commented Mar 31, 2021

Pls update merge master

@jak-pan jak-pan mentioned this pull request Mar 31, 2021
16 tasks
@green-jay green-jay changed the title feat!: governance WIP feat!: governance Mar 31, 2021
@jak-pan jak-pan changed the base branch from master to shedding March 31, 2021 19:24
@jak-pan jak-pan marked this pull request as ready for review March 31, 2021 19:24
@jak-pan jak-pan changed the title WIP feat!: governance feat!: governance Mar 31, 2021
@jak-pan jak-pan merged commit de06183 into shedding Mar 31, 2021
This was referenced Apr 1, 2021
@jak-pan jak-pan deleted the feat/governance branch May 9, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn off council nominations.
3 participants