refactor: pallet improvements and xyk pallet #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jak-pan
reviewed
May 4, 2021
jak-pan
reviewed
May 4, 2021
jak-pan
reviewed
May 4, 2021
jak-pan
reviewed
May 4, 2021
|
Let's remove amm |
ready. Should I test it in some specific way? obviously it is ok when starting a new chain. |
mrq1911
approved these changes
May 18, 2021
|
@enthusiastmartin LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Amm pallet refactor to remove HDX references and use of native asset instead.
Added XYK pallet - basically amm pallet renamed and amm pallet will be eventually replaced by this new xyk pallet ( first it needs few clarifications) and amm deprecated.
Few other minor code improvements as well.
Motivation and Context
Some pallets are used in basilisk node too where there is other than HDX asset as native currency. So it would make sense to remove hdx references from the code to be more generic.
How Has This Been Tested?
Tests.