Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade snakenet to v0.9.16 #363

Merged
merged 9 commits into from
Feb 18, 2022
Merged

Conversation

enthusiastmartin
Copy link
Contributor

@enthusiastmartin enthusiastmartin commented Feb 15, 2022

based on #358
fixes #362

runtime/common/src/lib.rs Outdated Show resolved Hide resolved
@mrq1911
Copy link
Member

mrq1911 commented Feb 16, 2022

spams this message when syncing, but still proceeds to sync

Listener: Ignoring invalid protocol:  due to A protocol (name) is invalid.    

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #363 (e4f1df2) into master (5eaf03e) will increase coverage by 0.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #363      +/-   ##
=========================================
+ Coverage    1.61%   1.63%   +0.01%     
=========================================
  Files           9       9              
  Lines        5635    5638       +3     
=========================================
+ Hits           91      92       +1     
- Misses       5544    5546       +2     
Impacted Files Coverage Δ
pallets/claims/src/migration.rs 63.63% <ø> (ø)
pallets/genesis-history/src/lib.rs 50.00% <ø> (ø)
pallets/claims/src/lib.rs 76.92% <50.00%> (-2.67%) ⬇️
pallets/claims/src/benchmarking.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 222d81c...e4f1df2. Read the comment docs.

@enthusiastmartin
Copy link
Contributor Author

enthusiastmartin commented Feb 16, 2022

spams this message when syncing, but still proceeds to sync

Listener: Ignoring invalid protocol:  due to A protocol (name) is invalid.    

protocol name is set for grandpa config. currently set to default value. What name can it be set to ? any hints ?

@mrq1911
Copy link
Member

mrq1911 commented Feb 16, 2022

spams this message when syncing, but still proceeds to sync

Listener: Ignoring invalid protocol:  due to A protocol (name) is invalid.    

protocol name is set for grandpa config. currently set to default value. What name can it be set to ? any hints ?

i would use "standard procotol name" construction as is used in polkadot https://github.com/paritytech/polkadot/blob/43b390f289fbe2054fbc86dd91f79dee314dc689/node/service/src/lib.rs#L777

@mrq1911
Copy link
Member

mrq1911 commented Feb 17, 2022

pls update deps to the latest polkadot-0.9.16 / release-0.9.16 revisions, parity cherrypicked new stuff there

@mrq1911 mrq1911 merged commit e8a2603 into master Feb 18, 2022
@jak-pan jak-pan deleted the polkadot-v0.9.16-solochain branch February 22, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Snakenet to Polkadot 0.9.16
2 participants