feat!: Integrate EMA oracle with Omnipool Hooks #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crate versions that have been updated:
Runtime version has been increased. |
apopiak
commented
Mar 10, 2023
…X-node into feat/oracle-hooks
enthusiastmartin
force-pushed
the
feat/oracle-hooks
branch
from
badfab2
to
8f62291
Compare
jak-pan
reviewed
Mar 16, 2023
| } | ||
|
|
||
| fn on_hub_asset_trade(_: Origin, _: AssetInfo<AssetId, Balance>) -> Result<(), Self::Error> { | ||
| Ok(()) | ||
| fn on_hub_asset_trade(_: Origin, _: AssetInfo<AssetId, Balance>) -> Result<Weight, Self::Error> { |
There was a problem hiding this comment.
Is this triggered on every swap? Even on Asset <> Asset?
There was a problem hiding this comment.
on LRNA trade only.
…X-node into feat/oracle-hooks
… feat/oracle-hooks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #534 +/- ##
==========================================
- Coverage 38.84% 38.65% -0.19%
==========================================
Files 62 66 +4
Lines 4240 4421 +181
==========================================
+ Hits 1647 1709 +62
- Misses 2593 2712 +119
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Note: We might want to optimize the weights in terms of the HDX liquidity change possible on trade (e.g. only doing it once per block). |
… feat/oracle-hooks
jak-pan
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the EMA oracle pallet to the runtime and ingest data by using the
OmnipoolHooksAdapter.Motivation and Context
We want to have on-chain data that aggregates over timespans. E.g. aggregate trading volume over some time to change fees based on it.
How Has This Been Tested?
Includes an integration test.
Most of the tests are in the pallet and its corresponding math package.
Checklist:
SupportedPeriods