-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: oracle RV audit feedback #617
Conversation
Crate versions that have been updated:
Runtime version has not been increased. |
… apopiak/small-oracle-improvements
In the This adapter gets the price for an arbitrary asset pair TKN1 - TKN2, by multiplying the results of nominators and denominators for TKN1-LRNA, LRNA-TKN2, resulting in TKN1 - TKN2 asset pair price. I wonder whether we need to change something there due to this current PR. What do you think? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #617 +/- ##
==========================================
- Coverage 64.66% 64.63% -0.03%
==========================================
Files 130 130
Lines 9446 9450 +4
==========================================
Hits 6108 6108
- Misses 3338 3342 +4
☔ View full report in Codecov by Sentry. |
As discussed offline, not applicable for this PR. |
Various small improvements.
Short
period toall_periods
MAX_UNIQUE_ENTRIES
andtrades_estimation.py
timestamp
field toupdated_at
and add constructorinverted
function toRatio