Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: router ED leftover balance check #619

Merged
merged 10 commits into from
Jun 23, 2023
Merged

fix: router ED leftover balance check #619

merged 10 commits into from
Jun 23, 2023

Conversation

dmoka
Copy link
Contributor

@dmoka dmoka commented Jun 21, 2023

  • fix bug for the case when after a trade there is less than the existential deposit as user balance
  • use more descriptive errors instead of UnexpectedError

@dmoka dmoka changed the title Fix: router balance check with less than ED fix: router balance check with less than ED Jun 21, 2023
@dmoka dmoka changed the title fix: router balance check with less than ED fix: balance check in router when leftover balance is less than ED Jun 21, 2023
@github-actions
Copy link

github-actions bot commented Jun 21, 2023 •
edited
Loading

Crate versions that have been updated:

  • runtime-integration-tests: v1.7.15 -> v1.7.16
  • pallet-route-executor: v1.0.4 -> v1.0.5

Runtime version has not been increased.

mrq1911
mrq1911 requested changes Jun 21, 2023
View reviewed changes
pallets/route-executor/src/lib.rs Outdated Show resolved Hide resolved
pallets/route-executor/src/lib.rs Outdated Show resolved Hide resolved
@mrq1911 mrq1911 changed the title fix: balance check in router when leftover balance is less than ED fix: router ED leftover balance check Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023 •
edited
Loading

Codecov Report

Patch coverage: 81.81% and no project coverage change.

Comparison is base (5a5c448) 64.68% compared to head (b8b3e6b) 64.68%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #619   +/-   ##
=======================================
  Coverage   64.68%   64.68%           
=======================================
  Files         130      130           
  Lines        9444     9442    -2     
=======================================
- Hits         6109     6108    -1     
+ Misses       3335     3334    -1
Impacted Files Coverage Δ
pallets/route-executor/src/lib.rs 89.83% <81.81%> (+0.66%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mrq1911 mrq1911 merged commit 5cf6d1b into master Jun 23, 2023
8 checks passed
@jak-pan jak-pan deleted the fix/router-balance-check branch February 22, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrq1911 mrq1911 mrq1911 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmoka @mrq1911