feat: XCMP Benchmarking #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmoka
approved these changes
Nov 21, 2023
|
Crate versions that have not been updated:
Runtime version has not been increased. |
Roznovjak
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
polkadot-sdkto the version with proper weight accounting and adjusts config and weights accordingly.We can only fit about 3 buckets worth of 20 messages each within the weight we have for xcmp processing.
Placing in the deferred queue is cheaper than processing, as it can adjust for the actual amount of messages in the bucket (that we're inserting into) rather than assuming worst case.
Also updates the template for weight file generation to include PoV sizes.
Motivation and Context
We want to make sure that we can fit the deferring as well as the processing of deferred XCMs within the allowed weight limits, so we need somewhat accurate benchmarks for these operations.
How Has This Been Tested?
Adds integration tests that ensure that the processing can happen within the weight limit.
Checklist: