fix: swaps of insufficient asset via evm #805
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operation fails already when MM does a dry-run estimateGas(...) on the transaction. When insufficient asset is bought, on_funds is triggered where we try to retrieve the price of the fee payment asset from the multi-pallet:
HydraDX-node/runtime/hydradx/src/assets.rs
Line 174 in 8abf856
But at the point of dry-run, the storage is empty, so it doesn't contain the accepted currency prices, as they are populated only in on_initialize of multi pallet.
The solution is to calculate the oracle onchain price directly instead of getting the prices from an empty prices storage of MultiPaymentPallet