-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Ayah from URL and /tafsir set and /atafsir set commands #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And capitalise word "al-Baqarah"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the context menu command that gets the Qur'an ayah from a URL
This was tested with the following links, all of which work as intended:
Closes #40
Rewrote the DBHandler child classes for less repetition
Made tafsir commands into a group:
/tafsir get ...
/tafsir set_default_tafsir
- not a flattering name, but up to you/atafsir get ...
/atafsir set_default_atafsir
This requires you to create new tables:
For Tafsir columns:
server
which is theguild_id
so up to you what datatypetafsir
which is thetafsir_name
similar to the translation name similarly stored, so a string-based datatype e.g "maarifulquran" will be storedFor Arabic Tafsir columns:
server
- theguild_id
atafsir
(could change the name), e.g: "tabari" will be storedCloses #55
Use the
app_commands.Range
annotation to have built in range check, that checks if the page is between 1 and 604 for/mushaf by_page
as well as for theday
month
andyear
args for/calendar
commandsUpdate the help command embed to make mention slash commands - closes #62