Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tone Mapping and Checkpoints #8

Closed
orzanai opened this issue Oct 4, 2022 · 2 comments
Closed

Tone Mapping and Checkpoints #8

orzanai opened this issue Oct 4, 2022 · 2 comments

Comments

@orzanai
Copy link

orzanai commented Oct 4, 2022

Hi, thank you for your effort and this great work!

I have some questions about tone mapping and checkpoints.
Do you think we can implement a tone mapping function for this model to automize post process instead of using another application?

Additionally, I trained model for 50 epoch and model have not been saving any checkpoint until now. I'm working on Google Colab so, if there is a way that making possible to get more checkpoints it would be great.

If do you have any idea about this questions, I'd be happy to hear that for further development.
Thanks in advance!

@orzanai orzanai changed the title Tone Mapping Tone Mapping and Checkpoints Oct 4, 2022
@Galaxies99
Copy link
Owner

Hi, thank you for your interest in our re-implementation of the DeepHDR!

We are not the original authors of the paper, and thus we only follow the paper to implement the method in pytorch.

I think the tone-mapping function can be added in the model, if the downstream applications is fixed. Otherwise I think it might be better to let the users to choose the type of tone-mapping methods according to their downstream applications.

Also, I think the train code is saving the checkpoints (see L141-142 of train.py). I would suggest you to check that whether configs.checkpoint_dir is correctly set, since it might not exist especially in CoLab environment.

@orzanai
Copy link
Author

orzanai commented Oct 6, 2022

Hi, thank you for your interest in our re-implementation of the DeepHDR!

We are not the original authors of the paper, and thus we only follow the paper to implement the method in pytorch.

I think the tone-mapping function can be added in the model, if the downstream applications is fixed. Otherwise I think it might be better to let the users to choose the type of tone-mapping methods according to their downstream applications.

Also, I think the train code is saving the checkpoints (see L141-142 of train.py). I would suggest you to check that whether configs.checkpoint_dir is correctly set, since it might not exist especially in CoLab environment.

Thank you so much for your fast answer, much appreciated!

@orzanai orzanai closed this as completed Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants