fix for hard-coded uwsgi ansible variable uwsgi_port #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello; this is a fix for a situation where a user specifies their own uwsgi_port in this role's default variables.
Port 4001 was hardcoded into the
supervisor.conftemplate, so galaxy_web uwsgi instances were listening on that port, howevernginx.confcorrectly picked up the new port and wasproxy_passing requests to the specified port.With this minor alteration, nginx and uwsgi once again have a harmonious relationship.
note: i wasn't able to find any other places where the port was hard-coded in, or any other hard-coded ports that could benefit from being turned in to variables, but am happy to make those alterations if there are some i've missed