Skip to content

Commit

Permalink
Add optional selection of client build type
Browse files Browse the repository at this point in the history
Building a client currently comes with 3 options for the type of build:
development, production and production with source maps.

The new client build task (see #52) defaults to the latter (production
with source maps). While there are good arguments for including source
maps with production code (useful for debugging, etc.), there should be
an easy and documented way for opting out when needed. One such use case
is size constraints (in my estimation, including source maps adds 35M).

By the same token, offering an option for a dev build seems reasonable,
especially considering that all three options are described in the
Galaxy client documentaion.
  • Loading branch information
jdavcs committed Feb 8, 2019
1 parent 3a90b7f commit 5230c2b
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 1 deletion.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,13 @@ Several variables control which functions this role will perform (all default to
- `galaxy_manage_database`: Upgrade the database schema as necessary, when new schema versions become available.
- `galaxy_fetch_dependencies`: Fetch Galaxy dependent modules to the Galaxy virtualenv.
- `galaxy_build_client`: Build the Galaxy client application (web UI).
- `galaxy_client_make_target` (default: `client-production`): Set the client build type. Options include: `client`,
`client-production` and `client-production-maps`. See [Galaxy client readme][client-build] for details.
- `galaxy_manage_errordocs` (default: `no`): Install Galaxy-styled 413 and 502 HTTP error documents for nginx. Requires
write privileges for the nginx error document directory.

[client-build]: https://github.com/galaxyproject/galaxy/blob/dev/client/README.md#complete-client-build

**Galaxy code and configuration**

Options for configuring Galaxy and controlling which version is installed.
Expand Down
8 changes: 8 additions & 0 deletions defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -249,3 +249,11 @@ galaxy_uwsgi_config_default:

# TODO: Implement something like this for starter/restarter
#galaxy_server_type: paste_singleprocess

#
# Client build settings
#

# Options include: client / client-production (default) / client-production-maps
galaxy_client_make_target: client-production

2 changes: 1 addition & 1 deletion tasks/client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
- name: Build client
make:
chdir: "{{ galaxy_server_dir }}"
target: client-production-maps
target: "{{ galaxy_client_make_target }}"
environment:
PATH: "{{ galaxy_venv_dir }}/bin:{{ ansible_env.PATH }}"
VIRTUAL_ENV: "{{ galaxy_venv_dir }}"
Expand Down

0 comments on commit 5230c2b

Please sign in to comment.