Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable galaxy_additional_venv_packages to install extra python packages in galaxy venv #150

Merged

Conversation

cat-bro
Copy link
Collaborator

@cat-bro cat-bro commented Apr 6, 2022

For issue #140

The use case for Galaxy Australia is needing to install the total-perspective-vortex package into the venv after it has been created but before the restart handler runs.

environment:
PYTHONPATH: null
VIRTUAL_ENV: "{{ galaxy_venv_dir }}"
when: galaxy_additional_venv_packages is not []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this check could be when: galaxy_additional_venv_packages, I think that should be falsey?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm not sure why I thought that when would work.

Good CI btw!

Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, I've written something similar, but never contributed it back, awesome :)

@hexylena
Copy link
Member

hexylena commented Apr 8, 2022

fab!

@hexylena hexylena merged commit 746f804 into galaxyproject:main Apr 8, 2022
natefoo added a commit to galaxyproject/ansible-collection-galaxy that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants