New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds subnet_id to launch method. #169
Conversation
… to pass security group ids instead of security group names to bypass a bug in boto.
The travis build seems to have failed for a reason unrelated to my changes. I can build this locally:
Some of the idiosyncracies of the boto call have been described where I am using them in Cloudlaunch |
@@ -253,13 +260,14 @@ def create_cm_security_group(self, sg_name='CloudMan'): | |||
cmsg = self.ec2_conn.create_security_group(sg_name, 'A security ' | |||
'group for CloudMan') | |||
except EC2ResponseError as e: | |||
err_msg = "Problem creating security group '{0}': {1} (code {2}; " \ | |||
err_msg = "Problem creaInvalid value 'null' for protocol. VPC security group rules must specify protocols explicitlyting security group '{0}': {1} (code {2}; " \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
creaInvalid... explicitlyting
: I think you pasted in the wrong place!
The TravisCI failed on Galaxy
|
Tested this manually and it worked fine so merged in (with a minor whitespace fix). |
I've fixed the TravisCI failures due to the Galaxy eggs-to-wheels migration, future PRs should be fine. |
Thank you all |
This pull request fixes two issues with boto.
Let me know what you want to see here.
run_instances
method, I get the following error. This seems to be a incompletely addressed idiosyncracy of the boto library and how it prefers for subnets to be specified. See this stackoverflow post and this github issue related to the run_instances call with a subnet_id. It seems that boto prefers subnet ids over subnet names in this method.