Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure project namespace is used instead of project name #122

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

nuwang
Copy link
Member

@nuwang nuwang commented Jun 9, 2020

Currently, some places in the code is using project.name instead of project.namespace, which results in errors if the project.name has spaces or is not RFC1123 compliant.
It looks like we also need more than just project.name in the context. Have added the following:

context.project.name
context.project.namespace
context.project.access_path

Will probably need the domain name in the context too.

@nuwang nuwang requested a review from almahmoud June 9, 2020 09:12
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 94.096% when pulling 20e3ffb on use_project_namespace into 173ad5e on master.

@nuwang nuwang merged commit 30771df into master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants