Improve handling of conditional requirements to match Galaxy #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 24, 2023
Merged
|
After setting |
|
And this is what the k8s-requirements.txt file looks like: galaxy@d44d9b401c46:/galaxy/server/lib/galaxy/dependencies$ cat k8s-requirements.txt
-r pinned-requirements.txt
psycopg2-binary==2.9.5
pykube==0.15.0
total-perspective-vortex<3 |
|
When I was looking to resume image builds a couple of weeks ago, I had to disable systemd handler as well: b7751ff#diff-6377f8a1937054624eac73b02854e7f99081cb731582fcecd1b435c5ded73120R18 Is the Galaxy role working without it now? Also, this will work for 23.0 and TPV <3. What about 22.05? |
|
On 22.05, it will pickup total-perspective-vortex<2 from the requirements, so all should be well. It didn't complain about systemd, started up and served the web ui. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables k8s specific requirements to be handled in a more robust way, respecting any constraints specified in Galaxy's conditional requirements file.