Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty document validation #144

Merged
merged 1 commit into from Jun 3, 2021
Merged

Fix empty document validation #144

merged 1 commit into from Jun 3, 2021

Conversation

davelopez
Copy link
Collaborator

Empty XML documents were considered invalid, this prevented some features like auto-completion to properly work at the beginning.
Empty XML documents are now considered to be Galaxy tool documents by default until the root element is fully declared.
Also, when an empty document is opened, it won't be validated right away to avoid displaying the Document is empty validation error but It will be displayed if you attempt to save it though.

Empty documents where considered invalid, so the autocompletion features didn't work. Now empty documents are suposed to be tool documents until the root element is declared.
@davelopez davelopez added bug Something isn't working language server Related to the language server labels Jun 3, 2021
@davelopez davelopez added this to the v0.5.1 milestone Jun 3, 2021
@davelopez davelopez merged commit e063a91 into master Jun 3, 2021
@davelopez davelopez deleted the fix_empty_doc_is_valid branch June 3, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working language server Related to the language server
Projects
Galaxy Language Server
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

1 participant