Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor validation #205

Merged
merged 8 commits into from Sep 21, 2022
Merged

Refactor validation #205

merged 8 commits into from Sep 21, 2022

Conversation

davelopez
Copy link
Collaborator

@davelopez davelopez commented Sep 11, 2022

Follow up on #204

Some general refactorings and cleanups around validation and linting.

Rename GalaxyToolValidationService to GalaxyToolSchemaValidationService and use diagnostics_source instead of server_name
This needs further refactoring... just a quick solution for now
Since galaxy utils load_with_references needs real filenames to load.
@davelopez davelopez added language server Related to the language server enhancement New feature or request labels Sep 21, 2022
@davelopez davelopez marked this pull request as ready for review September 21, 2022 08:45
@davelopez davelopez merged commit 33cf711 into main Sep 21, 2022
@davelopez davelopez deleted the refactor_validation branch September 21, 2022 08:45
@davelopez davelopez added this to the v0.8.0 milestone Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request language server Related to the language server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant