Don't clobber other Galaxies' systemd units when managed by different Gravity config files #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More specifically, ones that are related to a loaded Gravity config file. If you need to remove everything, you can use --clean --force. Related, update --force is obsolete on its own since the thing it originally did (always write PM configs regardless of whether the configstate changed) is meaningless now that there's no configstate: the PM configs are templated every time you run update, and are updated if they differ from what's on disk. The supervisor PM should probably switch to the systemd PM's logic here for --force. Tests for the desired behavior with --force and --update when multiple configs are used would also be good.
|
Ok, I went ahead and restored automatic updating on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on #82.
Also, it's worth mentioning that the
--forceoption toupdateon its own is mostly meaningless since that was necessary for forcing the supervisor configs to update when there were no changes to the configstate, but the configstate is gone and we template the configs every time and update them if there are any differences.Passing
--cleantoupdatewill remove any process manager configs for Galaxy instances known to this Gravity.Passing
--clean --forcetoupdatewill remove all process manager configs regardless of whether they are known to this Gravity (although in the case of supervisor, they probably live in an isolated directory in your Galaxy install).