Fix 2 typos #62
Merged
Fix 2 typos #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: ``` gxformat2/yaml.py:8: error: Library stubs not installed for "yaml" (or incompatible with Python 3.8) gxformat2/yaml.py:8: note: Hint: "python3 -m pip install types-PyYAML" gxformat2/interface.py:10: error: Library stubs not installed for "six" (or incompatible with Python 3.8) gxformat2/interface.py:10: note: Hint: "python3 -m pip install types-six" gxformat2/cytoscape.py:8: error: Library stubs not installed for "pkg_resources" (or incompatible with Python 3.8) gxformat2/cytoscape.py:8: note: Hint: "python3 -m pip install types-setuptools" gxformat2/schema/v19_09.py:76: error: Library stubs not installed for "requests" (or incompatible with Python 3.8) gxformat2/schema/v19_09.py:76: note: Hint: "python3 -m pip install types-requests" gxformat2/schema/v19_09.py:76: note: (or run "mypy --install-types" to install all missing stub packages) gxformat2/schema/v19_09.py:76: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports ```
mvdbeek
reviewed
Jul 7, 2021
mvdbeek
reviewed
Jul 7, 2021
mvdbeek
reviewed
Jul 7, 2021
| @@ -25,37 +25,33 @@ def main(argv): | |||
| else: | |||
| dev_version = re.compile(r'dev([\d]+)').search(version).group(1) | |||
| new_dev_version = int(dev_version) + 1 | |||
| new_version = version.replace("dev%s" % dev_version, "dev%s" % new_dev_version) | |||
| new_version = version.replace(f"dev{dev_version}", f"dev{new_dev_version}") | |||
There was a problem hiding this comment.
This script has been copy-pasted between various projects, do we need to correct this in other places as well ?
There was a problem hiding this comment.
It's not really a correction, I just modernised the code with pyupgrade now that we support Python >=3.6 only.
I think updating these scripts together with the rest of each project is OK, but we could surely update the "source" from where they are copied from, if there's one (@jmchilton should know).
There was a problem hiding this comment.
Who knows 😆 - I just copied it from whatever project I had last touched probably.
Thanks for the updates and fixes.
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update code for Python >=3.6 only