Support lists as data inputs #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pretty unfortunate that we don't know when a list is valid and when it isn't without looking at the tool parameter, but this is needed to model inputs from different source steps connected to a multi data input.
mvdbeek
force-pushed
the
multi_input_connections
branch
from
687b69e
to
e741362
Compare
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
=======================================
Coverage 40.34% 40.34%
=======================================
Files 48 48
Lines 1896 1896
Branches 429 429
=======================================
Hits 765 765
Misses 1016 1016
Partials 115 115
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mvdbeek
force-pushed
the
multi_input_connections
branch
from
e741362
to
456edcc
Compare
jmchilton
reviewed
Sep 19, 2022
gxformat2/markdown_parse.py
Outdated
| @@ -59,12 +59,17 @@ def validate_galaxy_markdown(galaxy_markdown, internal=True): | |||
|
|
|||
| def invalid_line(template, **kwd): | |||
| if "line" in kwd: | |||
| kwd["line"] = line.rstrip("\r\n") | |||
There was a problem hiding this comment.
This code is replicated in Galaxy - did you pull those changes in?
There was a problem hiding this comment.
Hmm, the Galaxy code doesn't look like it'd pass, but I can try.
jmchilton
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty unfortunate that we don't know when a list is valid and when it isn't without looking at the tool parameter, but this is needed to model inputs from different source steps connected to a multi data input.