Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved shed_diff. #141

Closed
2 tasks done
jmchilton opened this issue Apr 25, 2015 · 1 comment
Closed
2 tasks done

Improved shed_diff. #141

jmchilton opened this issue Apr 25, 2015 · 1 comment
Labels
enhancement toolshed

Comments

@jmchilton
Copy link
Member

shed_diff should...

  • Build actual tar balls and diff those (so ignored files like .shed.yml are not included).
  • Have a default enabled mode like that does an actual XML diff of TS artifacts and filters TS generated attribute changes - disable with --raw.

After these changes shed_diff will be ready for realized repositories and will be able to predict if a shed_upload will be needed. After that, shed-upload should diff before uploading.

This would completely alleviate my lingering concerns on galaxyproject/tools-iuc#50.
@jmchilton jmchilton mentioned this issue Apr 28, 2015
Closed
jmchilton added a commit that referenced this issue May 1, 2015
@jmchilton
Update shed_diff and shed_download for multi-repo-shed-yamls.
40a1f57 
 - Both realize repositories for configuration.
 - Both can now take in -r/--recursive arguments.
 - Download will attempt to download many repositories at once.
 - shed_diff now operates properly on the realized files instead of the local directory.

Still need to do a "smart diff" that filters out toolshed and changeset_revision attributes before #141 can be closed.
@jmchilton jmchilton mentioned this issue May 1, 2015
Merged
@jmchilton
Copy link
Member Author

Fixed with 40a1f57 and #167.

@jmchilton jmchilton mentioned this issue May 1, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement toolshed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmchilton