New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-include does not ignore #example# or example~ files #179

Closed
peterjc opened this Issue May 5, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@peterjc
Copy link
Contributor

peterjc commented May 5, 2015

e.g. Tar-ball contains temp files from common Unix editors:

$ planemo shed_upload --tar_only  ~/repositories/pico_galaxy/tools/nlstradamus/ && tar -xvf shed_upload.tar.gz
cp '/tmp/tmpDhxzFT' 'shed_upload.tar.gz'
#README.rst#
README.rst~
README.rst
nlstradamus.xml
tool_dependencies.xml

Either planemo needs some additional default excludes, or perhaps it could read the local .gitignore to expand the exclude list? (I would have said that was too magic, but planemo seems to do a lot of clever stuff like this already)

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented May 5, 2015

Indeed - seems like a good idea.

@erasche

This comment has been minimized.

Copy link
Member

erasche commented May 5, 2015

+1 to gitignore, though that will definitely look like magic.

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented May 5, 2015

I would rather explicitly exclude *~ and #*# patterns (in an eventually overriddable way) than worry about .gitignore (I'll try to do this soon). There may in fact be derived artifacts that should be tarred up but should not be in the git repository - so I think it would be best to ignore .gitignore.

@jmchilton jmchilton closed this in 66a5166 May 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment