-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Planemo fetches old database #61
Comments
I actually tried to implement this in the galaxy_downloads repo but botched it, let me review what went wrong. |
Ah, so not as simple it could be. Someone just needs to publish an ftp directory of them... (or for the code to understand github's view of a symlink) |
Minor progress figuring this out (maybe -- you can get the contents anyway): |
Huh. I would've figured that a request to https://raw.githubusercontent.com/dannon/galaxy-downloads/master/latest.sqlite with that header would've responded correctly, but it looks like it's JUST the API that responds that way. That's bloody annoying. Okay, my vote is for changing planemo/planemo/galaxy_config.py Line 71 in 4250874
from DATABASE_TEMPLATE_URL = DOWNLOADS_URL + "db_gx_rev_0120.sqlite" to import urllib
LATEST_URL = "https://raw.githubusercontent.com/jmchilton/galaxy-downloads/master/latest.sqlite"
DATABASE_TEMPLATE_URL = DOWNLOADS_URL + urllib.urlopen(LATEST_URL).read() It's too easy...even if it isn't as clean as some solution which would redirect properly. |
Annoying that github won't just serve the file, but I think this solution is fine. I can mirror the change in galaxy's test framework, since it has the same issue. |
I may roll this back or tweak it somehow - I don't like that planemo is now incompatible with the latest stable. I feel like too old is better than too new. Wonder if it is possible to just force Galaxy to use the newer database - in many cases it would probably just work. |
I noticed that too in my testing. I agree, that's unpleasant behaviour. maybe it would make sense to:
Or something like that. |
I think I want to move this functionality into Galaxy's |
Sure, that'd make sense too. |
relevant line
Instead of fetching a specific revision that will slowly age out, how about just symlinking it (or providing a 'latest')?
The text was updated successfully, but these errors were encountered: