Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linting: Check for suitable README file #89

Closed
peterjc opened this issue Mar 6, 2015 · 2 comments
Closed

linting: Check for suitable README file #89

peterjc opened this issue Mar 6, 2015 · 2 comments

Comments

@peterjc
Copy link
Contributor

peterjc commented Mar 6, 2015

Occasionally tool authors use README.md or similar.

Planemo lint could warn if the preferred form README.rst is not present (is that the IUC preference? We should say so on https://wiki.galaxyproject.org/Tools/BestPractices if so)

Planemo lint could error in there is no recognised readme file at all (README.txt, repository_name.txt, or README.rst, etc - using same listing as the Tool Shed code).

@peterjc peterjc changed the title Check for suitable README file linting: Check for suitable README file Mar 6, 2015
@jmchilton jmchilton mentioned this issue Mar 24, 2015
11 tasks
@jmchilton
Copy link
Member

Relevant Tool Shed code:

def get_readme_file_names( repository_name ):
    """Return a list of file names that will be categorized as README files for the received repository_name."""
    readme_files = [ 'readme', 'read_me', 'install' ]
    valid_filenames = map( lambda f: '%s.txt' % f, readme_files )
    valid_filenames.extend( map( lambda f: '%s.rst' % f, readme_files ) )
    valid_filenames.extend( readme_files )
    valid_filenames.append( '%s.txt' % repository_name )
    valid_filenames.append( '%s.rst' % repository_name )
    return valid_filenames

There is a couple there - probably the IUC should specify a best practice of just README, README.txt, or README.rst.

@jmchilton
Copy link
Member

Also along the same lines soon shed_upload will automatically filter out readmes for package and suite definitions so the best practice should just be every repository has a readme in github I suppose.

jmchilton@19e304c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants