New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner names in shed.yml files #898

Closed
ppouchin opened this Issue Nov 22, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@ppouchin
Copy link

ppouchin commented Nov 22, 2018

A team I know has a toolshed account with a public name containing an underscore, but planemo says that:

Owner must contain only lower-case letters, numbers and '-'

However, the toolshed states that:

Public names must be at least three characters in length and contain only lower-case letters, numbers, dots, underscores, and dashes ('.', '_', '-').

Is it normal?

@martenson

This comment has been minimized.

Copy link
Member

martenson commented Nov 22, 2018

Underscores in usernames are allowed since 16.10 (galaxyproject/galaxy@0e0b773)

Planemo needs to update docs.

@ppouchin

This comment has been minimized.

Copy link
Author

ppouchin commented Nov 22, 2018

And this line too, right?

VALID_PUBLICNAME_RE = re.compile(r"^[a-z0-9\-]+$")

@martenson

This comment has been minimized.

Copy link
Member

martenson commented Nov 22, 2018

@ppouchin the validation in planemo is wrong too, fixing it right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment