New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for automatic repo creation #101

Closed
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@erasche
Copy link
Member

erasche commented Mar 17, 2015

Should this be on by default? That's my only real question. If planemo can't find the target repository, it'll automatically create one.

Depends on bioblend > galaxyproject/bioblend#124

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Mar 17, 2015

Yeah - my preference would be we not be automatically creating stuff by default. I would prefer a -f/--force flag on shed_upload and a separate shed_create action (though we can deal with the separate action post PR). Is this okay with you?

@erasche

This comment has been minimized.

Copy link
Member Author

erasche commented Mar 17, 2015

Yep, absolutely. Give me a few minutes and I'll have it updated!

@martenson

This comment has been minimized.

Copy link
Member

martenson commented Mar 17, 2015

+1 with John, create repos carefully as they cannot be uncreated :)

@erasche erasche referenced this pull request Mar 17, 2015

Closed

Automate pushing to TTS/MTS #73

8 of 8 tasks complete
Eric Rasche
@erasche

This comment has been minimized.

Copy link
Member Author

erasche commented Mar 17, 2015

@jmchilton okay, repo creation is now off by default and optional.

I'll make a separate PR with shed repo creation (though that starts to overlap with parsec)

@erasche

This comment has been minimized.

Copy link
Member Author

erasche commented Mar 17, 2015

@jmchilton okay, human names are now in use. .shed.ymls look like:

name: gatk2
owner: iuc
description: The Genome Analysis Toolkit in Version 2
long_description: |
  The Genome Analysis Toolkit or GATK is a software package developed
  at the Broad Institute to analyse next-generation resequencing data. The toolkit
  offers a wide variety of tools, with a primary focus on variant discovery and
  genotyping as well as strong emphasis on data quality assurance. Its robust architecture,
  powerful processing engine and high-performance computing features make it capable
  of taking on projects of any size.

  http://www.broadinstitute.org/gatk/about/

  Repository-Maintainer: Bjoern Gruening, Nicola Soranzo and Jim Johnson
  Repository-Development: https://github.com/galaxy-iuc/tool_shed
type: unrestricted
categories:
    - Sequence Analysis

the category name must match precisely (capitalisation/spaces aren't stripped).

Eric Rasche added some commits Mar 18, 2015

Eric Rasche
Make linters/people happy
*Completely* useless message, but linters hate unused variables, and humans
dislike bare exceptions
Eric Rasche
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 18, 2015

Coverage Status

Coverage decreased (-1.53%) to 66.38% when pulling 3b50ddf on erasche:create-repo into a34e5fc on galaxyproject:master.

@erasche

This comment has been minimized.

Copy link
Member Author

erasche commented Mar 18, 2015

Oh, lovely, now coveralls is kvetching at me in addition to the linters.

@jmchilton afaict none of the toolshed interactions are actually under test, and I'm not keen to write those...

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Mar 18, 2015

Ignore coveralls - it is annoying.

Update: Disabled the alerts (I certainly never meant to enable them in the first place :)).

@erasche

This comment has been minimized.

Copy link
Member Author

erasche commented Mar 18, 2015

@jmchilton anything else you want for this PR?

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Mar 18, 2015

Not at first glace - this looks pretty awesome - thanks! I want to find some time to actually play with it before merging though.

@martenson You have thought a lot more than me about this issue - does this seem right to you? Do you feel like the correct things are being stored in .shed.yml in the correct format.

@erasche

This comment has been minimized.

Copy link
Member Author

erasche commented Mar 18, 2015

@jmchilton sure, no rush! On that note, there may be a small bug in type, which I need to double check.

@martenson

This comment has been minimized.

Copy link
Member

martenson commented Mar 18, 2015

@jmchilton @erasche I think it is a good start but we know the target is moving. We are not creating standard yet, just exploring.

@erasche

This comment has been minimized.

Copy link
Member Author

erasche commented Mar 18, 2015

@jmchilton okay, that bug in type is actually upstream in galaxyproject/galaxy#31 (so this commit should be technically correct, but my comments on "no rush" still stand)

Remove useless exception
Thanks @jmchilton for making me aware of `except:` vs `except Exception:`
@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Mar 19, 2015

Crap - I merged the commits with a real merge so the PR would close when I pushed but then I rebased things out of vanity and the merge information got lost. Sorry about that - the commits are nonetheless in there - I hope that is okay.

@jmchilton jmchilton closed this Mar 19, 2015

@erasche

This comment has been minimized.

Copy link
Member Author

erasche commented Mar 19, 2015

No worries! Also, thanks for adding the test case. I'll make sure my future PR make some attempts to include those :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment