New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Edited NO_TEST_DATA_MESSAGE to refer to --test_data, not --test-data #129

Merged
merged 1 commit into from Apr 16, 2015

Conversation

Projects
None yet
2 participants
@pvanheus
Copy link
Contributor

pvanheus commented Apr 16, 2015

0.3.0 (2015-02-13) changed --test-data to --test_data, but the NO_TEST_DATA_MESSAGE was referring to --test-data.

The code still looks for a default directory called test-data though. Perhaps this should be changed to test_data or it should look for both test-data and test_data?

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Apr 16, 2015

Thanks for the fix, Galaxy and the tool shed call the directory test-data but all the planemo command-line parameters use _. I think this is okay since one thing is a command line and one is a file and those can have differing conventions, though if I could do it over I might have gone with - for Planemo's command-line parameters.

jmchilton added a commit that referenced this pull request Apr 16, 2015

Merge pull request #129 from pvanheus/master
* Edited NO_TEST_DATA_MESSAGE to refer to --test_data, not --test-data

@jmchilton jmchilton merged commit 213211c into galaxyproject:master Apr 16, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment